kobo attachments error handling

Author: tijsziere

routes/routes121.py

@@ -520,7 +520,7 @@ async def create_121_program_from_kobo(
         )
 
     if len(MISSINGFIELDS) != 0:
-        print("Missing hidden fields in the template: ", MISSINGFIELDS)
+        logger.error(f"Missing required keys in kobo form: {MISSINGFIELDS}")
         raise HTTPException(
             status_code=400,
             detail=f"Missing required keys in kobo form: {MISSINGFIELDS}",

utils/utilsKobo.py

@@ -2,6 +2,7 @@
 import time
 from fastapi import Header
 import sys
+from utils.logger import logger
 
 
 def required_headers_kobo(kobotoken: str = Header(), koboasset: str = Header()):
@@ -34,31 +35,60 @@ def get_kobo_attachment(URL, kobo_token):
 def get_attachment_dict(kobo_data, kobotoken=None, koboasset=None):
     """Create a dictionary that maps the attachment filenames to their URL."""
     attachments, attachments_list = {}, []
-    if kobotoken and koboasset and "_id" in kobo_data.keys():
-        time.sleep(30)
-        headers = {"Authorization": f"Token {kobotoken}"}
-        URL = f"https://kobo.ifrc.org/api/v2/assets/{koboasset}/data/{kobo_data['_id']}/?format=json"
-        data_request = requests.get(URL, headers=headers)
-        data = data_request.json()
-        if "_attachments" in data.keys():
-            attachments_list = data["_attachments"]
-    if len(attachments_list) == 0:
-        if "_attachments" in kobo_data.keys():
-            attachments_list = kobo_data["_attachments"]
-        for attachment in attachments_list:
-            filename = attachment["filename"].split("/")[-1]
-            downloadurl = attachment["download_large_url"]
-            mimetype = attachment["mimetype"]
-            attachments[filename] = {"url": downloadurl, "mimetype": mimetype}
-    else:
-        for attachment in attachments_list:
-            filename = attachment["filename"].split("/")[-1]
-            downloadurl = (
-                "https://kc.ifrc.org/media/original?media_file="
-                + attachment["filename"]
-            )
-            mimetype = attachment["mimetype"]
-            attachments[filename] = {"url": downloadurl, "mimetype": mimetype}
+    
+    try:
+        if kobotoken and koboasset and "_id" in kobo_data.keys():
+            time.sleep(30)
+            headers = {"Authorization": f"Token {kobotoken}"}
+            URL = f"https://kobo.ifrc.org/api/v2/assets/{koboasset}/data/{kobo_data['_id']}/?format=json"
+            
+            try:
+                data_request = requests.get(URL, headers=headers, timeout=30)
+                data_request.raise_for_status()
+                data = data_request.json()
+                
+                if "_attachments" in data.keys():
+                    attachments_list = data["_attachments"]
+                    logger.info(f"Retrieved {len(attachments_list)} attachments from API for submission {kobo_data['_id']}")
+            except requests.exceptions.RequestException as e:
+                logger.error(f"Failed to fetch attachment data from Kobo API for submission {kobo_data['_id']}: {e}")
+                # Fall back to using attachments from kobo_data if available
+            except ValueError as e:
+                logger.error(f"Failed to parse JSON response from Kobo API: {e}")
+        
+        if len(attachments_list) == 0:
+            if "_attachments" in kobo_data.keys():
+                attachments_list = kobo_data["_attachments"]
+                logger.info(f"Using {len(attachments_list)} attachments from kobo_data")
+            for attachment in attachments_list:
+                try:
+                    filename = attachment["filename"].split("/")[-1]
+                    downloadurl = attachment["download_url"]
+                    mimetype = attachment["mimetype"]
+                    attachments[filename] = {"url": downloadurl, "mimetype": mimetype}
+                except KeyError as e:
+                    logger.warning(f"Missing expected key in attachment: {e}. Skipping attachment.")
+                    continue
+        else:
+            for attachment in attachments_list:
+                try:
+                    filename = attachment["filename"].split("/")[-1]
+                    downloadurl = (
+                        "https://kc.ifrc.org/media/original?media_file="
+                        + attachment["filename"]
+                    )
+                    mimetype = attachment["mimetype"]
+                    attachments[filename] = {"url": downloadurl, "mimetype": mimetype}
+                except KeyError as e:
+                    logger.warning(f"Missing expected key in attachment: {e}. Skipping attachment.")
+                    continue
+        
+        logger.info(f"Successfully processed {len(attachments)} attachments")
+        
+    except Exception as e:
+        logger.error(f"Unexpected error in get_attachment_dict: {e}")
+        return {}
+    
     return attachments