Make logrotate.conf into a template with defined type#15
Open
apowers wants to merge 3 commits intorodjek:masterfrom
Open
Make logrotate.conf into a template with defined type#15apowers wants to merge 3 commits intorodjek:masterfrom
apowers wants to merge 3 commits intorodjek:masterfrom
Conversation
|
+1 |
|
If i'm reading this right, it would not touch the logrotate.conf if you don't specify to edit it correct? that would be awesome. Documented my thoughts in #33 |
|
+1 |
|
I guess since this PR is a total mess. There were 2 commits added which having nothing to do with the actual PR. I've cleaned it up myself (https://github.com/baurmatt/puppet-logrotate/tree/fix_pr15) but want to do some refactoring before creating a new PR. My idea was, to have one template which can be used for /etc/logrotate.conf and /etc/logrotate.d/* since those files are exactly the same beside the additional "<%= rpath %> {" and "}" lines. @rodjek some thoughts about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is useful to be able to set defaults for all logrotate logs, especially for those that may be vendor installed and not specifically managed by puppet.
This update converts logrotate.conf from a static file to a template using a defined type very similar to the one used for rules.