Redirect ambiguous Cummins-Pauli label jumps to the full list of matching curves - #10
Closed
roed-math wants to merge 2 commits into
Closed
Redirect ambiguous Cummins-Pauli label jumps to the full list of matching curves#10roed-math wants to merge 2 commits into
roed-math wants to merge 2 commits into
Conversation
…#7043) Many modular curves can share a Cummins-Pauli label (e.g. 12C3 matches 2004 curves on beta), but the jump box silently picked one via lucky(). Now a CP label with a unique match still goes straight to the curve, while multiple matches redirect to the search results listing all curves with that CPlabel (the CPlabel search parameter already existed). Verified with the Flask test client (113A17 lists both matches, 100A7 goes to 100.120.7.a.1, 999Z9 still flashes an error, fiber-product jumps unchanged) and by extending test_jump, which passes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
GPT signed off. |
Owner
Author
|
Superseded by LMFDB#7147, opened upstream from this same branch. Closing here; review continues upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching the modular curve jump box for a Cummins-Pauli label such as
12C3used to resolve vialucky, silently landing on one arbitrary curve even though many curves can share a CP label (2004 for12C3on beta). Now, if the CP label matches a unique curve we go straight to it as before, whilemultiple matches redirect to the search results listing all curves with that
CPlabel. Labels with nomatch still flash the existing error, and fiber-product jumps are unchanged. Verified with the Flask
test client and by extending
test_jumpwith a unique CP label (100A7) and an ambiguous one(
113A17, whose two matches both appear in the results).Addresses LMFDB#7043.
🤖 Generated with Claude Code