Conversation
sponomarev
reviewed
Feb 13, 2025
|
|
||
| return resp.text(); | ||
| } catch (e){ | ||
| console.debug('Can not fetch link:', link); |
There was a problem hiding this comment.
Is it an appropriate pattern in the repo?
Owner
Author
There was a problem hiding this comment.
You mean to not throw the exception?
The best way is to handle these errors at Sentry or similar. As there is no tracker, I decided to just log it with console. It should be visible at Vercel that way afaik.
sponomarev
reviewed
Feb 13, 2025
sponomarev
reviewed
Feb 13, 2025
rogaldh
force-pushed
the
feat/link-feature-info
branch
from
88c276a to
b971763
Compare
Owner
Author
|
Merged at the upstream |
rogaldh
pushed a commit
that referenced
this pull request
Mar 19, 2025
…olana-foundation#499) ## Description <!-- Provide a brief description of the changes in this PR --> Adds support for viewing Squads `VaultTransaction`s in the transaction inspector. This is an additional layer of safety when using Squads, since users will be able to use the Explorer to verify a proposed transaction's contents on an independent platform. ## Type of change <!-- Check the appropriate options that apply to this PR --> - [x] New feature ## Screenshots <!-- For UI changes, especially protocol screens, include screenshots showing the changes --> <!-- This is REQUIRED for protocol integration PRs --> - Modified the card title to `Inspector Input` - Appended Squads support to placeholder text - Added a bullet point to `Instructions` section describing how to get the squads transaction id  ## Testing <!-- Describe how you tested your changes --> <!-- For protocol integrations, explain how you verified the protocol data is correctly displayed --> - [ ] in progress ## Related Issues <!-- Link to any related issues this PR addresses --> <!-- Example: Fixes solana-foundation#123, Addresses solana-foundation#456 --> ## Checklist <!-- Verify that you have completed the following before requesting review --> - [x] My code follows the project's style guidelines - [ ] I have added tests that prove my fix/feature works - [ ] All tests pass locally and in CI - [x] have updated documentation as needed - [x] CI/CD checks pass - [x] I have included screenshots for protocol screens (if applicable) - [ ] For security-related features, I have included links to related information ## Additional Notes <!-- Add any other context about the PR here --> <!-- For Solana Verify (Verified Builds) related changes, note that bugs should be reported to disclosures@solana.org --> <!-- ELLIPSIS_HIDDEN --> ---- > [!IMPORTANT] > Adds support for Squads Vault Transactions in the transaction inspector, including UI updates and tests. > > - **Behavior**: > - Adds support for Squads `VaultTransaction` in `InspectorPage.tsx`. > - Introduces `SquadsProposalAccountData` type and `isSquadsProposalAccountData()` function. > - Updates `decodeUrlParams()` to handle `squadsTx` parameter. > - Implements `SquadsProposalInspectorCard` to fetch and display Squads transaction data. > - **UI Changes**: > - Modifies `RawInputCard.tsx` to accept Squads vault transaction accounts. > - Updates placeholder text and instructions in `RawInputCard.tsx`. > - **Testing**: > - Adds tests in `InspectorPage.spec.tsx` for Squads transaction handling. > - **Dependencies**: > - Adds `@sqds/multisig` to `package.json`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=solana-foundation%2Fexplorer&utm_source=github&utm_medium=referral)<sup> for 4220460. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN --> --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
rogaldh
pushed a commit
that referenced
this pull request
Mar 20, 2025
…ns (#2)" (solana-foundation#503) Reverts solana-foundation#499 <!-- ELLIPSIS_HIDDEN --> ---- > [!IMPORTANT] > Revert support for Squads Vault Transactions in the Transaction Inspector, removing related code and dependencies. > > - **Revert Squads Vault Transactions**: > - Remove `SquadsProposalInspectorCard` and related logic from `InspectorPage.tsx`. > - Delete `InspectorPage.spec.tsx` test file. > - Remove `@sqds/multisig` dependency from `package.json`. > - **Code Adjustments**: > - Change `bs58` to `base58` in `InspectorPage.tsx` and `RawInputCard.tsx`. > - Simplify `RawInput` component to only handle base64 encoded transaction messages. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=solana-foundation%2Fexplorer&utm_source=github&utm_medium=referral)<sup> for e9f1bbc. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
rogaldh
added a commit
that referenced
this pull request
Jan 24, 2026
…-foundation#814) ## Description - adding instructions how to upload idl for programs without idl - displaying idl tab for all program account ## Type of change - [x] New feature ## Screenshots <img width="1138" height="416" alt="image" src="https://github.com/user-attachments/assets/f73e0741-fb38-433f-a97e-04cd67daf185" /> ## Testing case #1 1. open http://localhost:3000/address/2NqsQ7zQ9fq8azdWe5NGTW2yrpSHhfogf7TkVavd8hDn/idl?cluster=devnet (program without idl) 2. see instructions case #2 1. open http://localhost:3000/address/compr6CUsB5m2jS4Y3831ztGSTnDpnKJTKS95d64XVq/idl (program with idl) 2. see info ## Related Issues [HOO-116](https://linear.app/solana-fndn/issue/HOO-116) ## Checklist - [x] My code follows the project's style guidelines - [x] All tests pass locally and in CI - [x] I have run `build:info` script to update build information - [x] CI/CD checks pass - [x] I have included screenshots for protocol screens (if applicable)-state) ## Checklist - [x] My code follows the project's style guidelines - [x] All tests pass locally and in CI - [x] I have run `build:info` script to update build information - [x] CI/CD checks pass - [x] I have included screenshots for protocol screens (if applicable) --------- Co-authored-by: Tania Markina <37657937+C0mberry@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream: solana-foundation#461