-
Notifications
You must be signed in to change notification settings - Fork 0
Impl timeout to suspend #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+61
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d33c750
to
c6b591a
Compare
Chikurin1014
requested changes
Aug 19, 2024
Chikurin1014
requested changes
Aug 19, 2024
Chikurin1014
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
INITIALIZING
-> SUSPEND
の状態遷移が発生しなくなった気がする。
RUNNING
に入った直後にSUSPEND
に遷移させれば良いので、個人的にはそこまで悪いことだとは思わないですが。
Issueで言及していた内容から逸れてくるけど、ここまで来るとOutputMachine
に組み込めそう。あるいはOutputMachineAsync
とかにしてまとめられそう。
動作確認できたらマージする |
落ちた
|
https://github.com/ARMmbed/mbed-os-example-fault-handler 使ってみた
|
Chikurin1014
requested changes
Aug 20, 2024
4641f91
to
faef06f
Compare
faef06f
to
1b108a3
Compare
|
4610db2
to
e39be22
Compare
9109927
to
54a094c
Compare
なんと、動く |
b41c958
to
f275c28
Compare
Chikurin1014
requested changes
Aug 20, 2024
Chikurin1014
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11