Skip to content

Use msgpack for API#1176

Merged
Dekkonot merged 7 commits intorojo-rbx:masterfrom
nezuo:msgpack-api
Feb 13, 2026
Merged

Use msgpack for API#1176
Dekkonot merged 7 commits intorojo-rbx:masterfrom
nezuo:msgpack-api

Conversation

@nezuo
Copy link
Copy Markdown
Contributor

@nezuo nezuo commented Nov 27, 2025

Switches the rojo API to use msgpack instead of JSON.

Fixes #363.
Fixes #881.

@nezuo
Copy link
Copy Markdown
Contributor Author

nezuo commented Nov 27, 2025

JJ doesn't support git submodules 😢

@nezuo
Copy link
Copy Markdown
Contributor Author

nezuo commented Nov 27, 2025

I'm not sure if the tests are correct because some tests seem to run infinitely.

There is also this code in serve_utils that uses json. Not sure what this is for or if it needs to be updated.

Ok(Message::Text(text)) => {
                    let packet: SocketPacket = serde_json::from_str(&text)?;
                    if packet.packet_type != packet_type {
                        continue;
                    }

                    // Close the WebSocket connection now that we got what we were waiting for
                    let _ = socket.close(None);
                    return Ok(packet);
                }

EDIT: Fixed

@nezuo nezuo mentioned this pull request Nov 27, 2025
3 tasks
@nezuo
Copy link
Copy Markdown
Contributor Author

nezuo commented Nov 28, 2025

The protocolVersion will have to be bumped if this is not included in the upcoming release.


-- For NaN, check if both values are not equal to themselves
elseif a ~= a and b ~= b then
print("they are equal")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spare print statement you may want to remove

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks.

@Quenty
Copy link
Copy Markdown
Contributor

Quenty commented Dec 31, 2025

Note: There's weird failure modes for when plugin/rojo are out of sync here.

Quenty added a commit to Quenty/rojo that referenced this pull request Dec 31, 2025
Switches the rojo API to use msgpack instead of JSON.

Fixes rojo-rbx#363.
Fixes rojo-rbx#881.
Quenty added a commit to Quenty/rojo that referenced this pull request Dec 31, 2025
Switches the rojo API to use msgpack instead of JSON.

Fixes rojo-rbx#363.
Fixes rojo-rbx#881.
Quenty added a commit to Quenty/rojo that referenced this pull request Dec 31, 2025
Switches the rojo API to use msgpack instead of JSON.

Fixes rojo-rbx#363.
Fixes rojo-rbx#881.
Quenty added a commit to Quenty/rojo that referenced this pull request Dec 31, 2025
Switches the rojo API to use msgpack instead of JSON.

Fixes rojo-rbx#363.
Fixes rojo-rbx#881.
Dekkonot
Dekkonot previously approved these changes Jan 20, 2026
Copy link
Copy Markdown
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged another change to the web API without thinking about the impact on this PR but this looks good to me.

@nezuo
Copy link
Copy Markdown
Contributor Author

nezuo commented Feb 7, 2026

Tests pass on my machine, not sure what happened.

@Dekkonot Dekkonot merged commit 4deda0e into rojo-rbx:master Feb 13, 2026
13 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warning "value cannot be converted to a number" on Billboard Gui's "MaxDistance" property No support for infinity

3 participants