Merged
Conversation
Contributor
Author
|
JJ doesn't support git submodules 😢 |
Contributor
Author
|
I'm not sure if the tests are correct because some tests seem to run infinitely. There is also this code in serve_utils that uses json. Not sure what this is for or if it needs to be updated. Ok(Message::Text(text)) => {
let packet: SocketPacket = serde_json::from_str(&text)?;
if packet.packet_type != packet_type {
continue;
}
// Close the WebSocket connection now that we got what we were waiting for
let _ = socket.close(None);
return Ok(packet);
}EDIT: Fixed |
Contributor
Author
|
The |
Quenty
reviewed
Dec 31, 2025
plugin/src/Reconciler/diff.lua
Outdated
|
|
||
| -- For NaN, check if both values are not equal to themselves | ||
| elseif a ~= a and b ~= b then | ||
| print("they are equal") |
Contributor
There was a problem hiding this comment.
spare print statement you may want to remove
Contributor
|
Note: There's weird failure modes for when plugin/rojo are out of sync here. |
Quenty
added a commit
to Quenty/rojo
that referenced
this pull request
Dec 31, 2025
Switches the rojo API to use msgpack instead of JSON. Fixes rojo-rbx#363. Fixes rojo-rbx#881.
Quenty
added a commit
to Quenty/rojo
that referenced
this pull request
Dec 31, 2025
Switches the rojo API to use msgpack instead of JSON. Fixes rojo-rbx#363. Fixes rojo-rbx#881.
Quenty
added a commit
to Quenty/rojo
that referenced
this pull request
Dec 31, 2025
Switches the rojo API to use msgpack instead of JSON. Fixes rojo-rbx#363. Fixes rojo-rbx#881.
Quenty
added a commit
to Quenty/rojo
that referenced
this pull request
Dec 31, 2025
Switches the rojo API to use msgpack instead of JSON. Fixes rojo-rbx#363. Fixes rojo-rbx#881.
Dekkonot
previously approved these changes
Jan 20, 2026
Member
Dekkonot
left a comment
There was a problem hiding this comment.
I merged another change to the web API without thinking about the impact on this PR but this looks good to me.
Contributor
Author
|
Tests pass on my machine, not sure what happened. |
Dekkonot
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the rojo API to use msgpack instead of JSON.
Fixes #363.
Fixes #881.