Open
Conversation
Dekkonot
reviewed
Aug 3, 2023
Member
Dekkonot
left a comment
There was a problem hiding this comment.
I think it's actually probably fine to leave the template as model instead of library. It's the goto alternative to place, so it makes sense to me.
This reverts commit bde1550.
Member
|
Should we update the place to match the new Baseplate of Studio? |
Contributor
Author
|
It's a matter of preference but the current template we have has outdated Lighting properties. I think we should update it. Does anyone have any reservations about updating it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to start a discussion on improvements we can make to the old templates. If anyone disagrees with a change I made, let me know!
Here are the changes I made:
.gitignoreupdates:rojo fmt-projectdoesn't add a newline).READMEs now recommend the binary format instead of XML.rojo fmt-projecton the place project file. I'm not sold on this, the output is a little strange androjo fmt-projectisn't even deterministic.FilteringEnabledproperty from the place project file since it's always on by default now.I renamed themodeltemplate tolibraryto better reflect what it does.