Skip to content

Make the library buildable and the example compilable so we can publish and fix the CI #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ jobs:
name: Flutter version ${{ matrix.flutter_version }} (Android)
strategy:
matrix:
flutter_version: ["3.10.2"]
flutter_version: ["3.29.2"]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: actions/setup-java@v1
with:
java-version: "11.x"
- uses: subosito/flutter-action@4389e6cbc6cb8a4b18c628ff96ff90be0e926aa8
- uses: subosito/flutter-action@v2
with:
flutter-version: ${{ matrix.flutter_version }}
- name: Cache Dart and Gradle packages
uses: actions/cache@v2
uses: actions/cache@v4
with:
path: |
~/.gradle/caches
Expand Down Expand Up @@ -69,13 +69,13 @@ jobs:
- name: Build rollbar_flutter Android example
working-directory: ./rollbar_flutter/example/
run: flutter build apk
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: ${{ always() }}
# We are not supposed to lock our dependencies in packages or plugins, so we'll
# at least keep track of which ones were used in the build, in case a test fails
# and we need to reproduce it locally with the same dependencies.
with:
name: dependencies_used_${{ matrix.flutter_version }}
name: dependencies_used_${{ runner.os }}_${{ matrix.flutter_version }}_${{ github.run_id }}
path: |
rollbar_dart/pubspec.lock
rollbar_dart/example/pubspec.lock
Expand All @@ -87,15 +87,15 @@ jobs:
name: Flutter version ${{ matrix.flutter_version }} (iOS)
strategy:
matrix:
flutter_version: ["3.10.2"]
flutter_version: ["3.29.2"]

steps:
- uses: actions/checkout@v2
- uses: subosito/flutter-action@4389e6cbc6cb8a4b18c628ff96ff90be0e926aa8
- uses: actions/checkout@v4
- uses: subosito/flutter-action@v2
with:
flutter-version: ${{ matrix.flutter_version }}
- name: Cache pub packages
uses: actions/cache@v2
uses: actions/cache@v4
with:
path: |
${{ env.PUB_CACHE }}
Expand All @@ -109,11 +109,11 @@ jobs:
- name: Build rollbar_flutter iOS example
working-directory: ./rollbar_flutter/example/
run: flutter build ios --no-codesign
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: ${{ always() }}
# Save dependencies used
with:
name: dependencies_used_${{ matrix.flutter_version }}
name: dependencies_used_${{ runner.os }}_${{ matrix.flutter_version }}_${{ github.run_id }}
path: |
rollbar_dart/pubspec.lock
rollbar_dart/example/pubspec.lock
Expand Down
2 changes: 0 additions & 2 deletions rollbar_dart/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ linter:
- prefer_single_quotes
- sort_child_properties_last
- unawaited_futures
- unsafe_html

# For more information about the core and recommended set of lints, see
# https://dart.dev/go/core-lints

Expand Down
2 changes: 0 additions & 2 deletions rollbar_flutter/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,5 @@ linter:
- always_declare_return_types
- prefer_single_quotes
- unawaited_futures
- unsafe_html

# Additional information about this file can be found at
# https://dart.dev/guides/language/analysis-options
2 changes: 1 addition & 1 deletion rollbar_flutter/example/ios/Flutter/AppFrameworkInfo.plist
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
<key>CFBundleVersion</key>
<string>1.0</string>
<key>MinimumOSVersion</key>
<string>11.0</string>
<string>14.0</string>
</dict>
</plist>
2 changes: 1 addition & 1 deletion rollbar_flutter/example/ios/Podfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
platform :ios, '11.0'
platform :ios, '14.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
6 changes: 3 additions & 3 deletions rollbar_flutter/example/ios/Runner.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
SUPPORTED_PLATFORMS = iphoneos;
Expand Down Expand Up @@ -429,7 +429,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
SDKROOT = iphoneos;
Expand Down Expand Up @@ -478,7 +478,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
SUPPORTED_PLATFORMS = iphoneos;
Expand Down
2 changes: 1 addition & 1 deletion rollbar_flutter/ios/rollbar_flutter.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Connect your Flutter applications to Rollbar for error reporting.
s.dependency 'Flutter'
s.dependency 'RollbarNotifier', '~> 3.3.3'
s.static_framework = true
s.platform = :ios, '11.0'
s.platform = :ios, '14.0'

# Flutter.framework does not contain a i386 slice.
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES',
Expand Down
2 changes: 1 addition & 1 deletion rollbar_flutter/lib/src/platform_transformer.dart
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ extension _Message on Iterable<Trace> {
(extraTraces.tryFirst?.exception.message)
.map((message) => 'PlatformException(error, "$message")')
.map(replaceExceptionMessages)
.map(append ? extraTraces.followedBy : identity)
.map(append ? extraTraces.followedBy : (x) => x)
.or(this);

/// Propagates the given [message] as the new exception message, replacing
Expand Down
Loading