Skip to content

Fixed warnings and hints before publishing #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rollbar_common/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

- Updated http library to '>=0.13.0 <2.0.0'
- Updated uuid library to '^4.1.0'
- Updated sdk constraint to '>=2.17.0 <4.0.0'
- Fixed warnings about the value of 'identity' not being used.

## 1.1.0

Expand Down
2 changes: 1 addition & 1 deletion rollbar_common/lib/src/extension/function.dart
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ bool isNotNull<T>(T? x) => x != null;
/// ```
/// id := λx.x where x: bool ≡ bool isTrue(bool x) => x;
/// ```
const isTrue = identity<bool>;
bool isTrue(bool x) => x;

/// Tests whether the given boolean argument [x] is false.
///
Expand Down
2 changes: 1 addition & 1 deletion rollbar_common/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ documentation: https://docs.rollbar.com/docs/flutter#dart
repository: https://github.com/rollbar/rollbar-flutter

environment:
sdk: '>=2.17.0 <3.0.0'
sdk: '>=2.17.0 <4.0.0'

dependencies:
http: '>=0.13.0 <2.0.0'
Expand Down
4 changes: 2 additions & 2 deletions rollbar_common/test/table_set_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ void main() {
expect(payloadRecords.length, ++recordsCount);
}

for (final record in payloadRecords.map(identity)) {
for (final record in payloadRecords.map((x) => x)) {
expect(payloadRecords.remove(record), isTrue);
expect(payloadRecords.record(id: record.id), isNull);
expect(payloadRecords.length, --recordsCount);
Expand Down Expand Up @@ -152,7 +152,7 @@ void main() {
expect(payloadRecords.length, 16);

final transformResult = payloadRecords.map(records.contains);
expect(transformResult.all(identity), isTrue);
expect(transformResult.all((x) => x), isTrue);

for (final record in payloadRecords) {
expect(records.contains(record), isTrue);
Expand Down
1 change: 1 addition & 0 deletions rollbar_dart/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 1.3.2

- Updated http library to '>=0.13.0 <2.0.0'
- Updated sdk constraint to '>=2.17.0 <4.0.0'
- Fixed usage of unsafe_html which was removed in Dart 3.7.0.

## 1.3.1
Expand Down
2 changes: 1 addition & 1 deletion rollbar_dart/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ documentation: https://docs.rollbar.com/docs/flutter#dart
repository: https://github.com/rollbar/rollbar-flutter

environment:
sdk: '>=2.17.0 <3.0.0'
sdk: '>=2.17.0 <4.0.0'

dependencies:
http: '>=0.13.0 <2.0.0'
Expand Down
Loading