Fix JSON::GeneratorError for objects with invalid UTF-8 in to_s - #1199
Merged
Conversation
Rollbar::Encoding.encode only processed String and Symbol types. When objects with to_s methods returning invalid UTF-8 were included in the payload, they bypassed encoding and caused JSON serialization to fail with "source sequence is illegal/malformed utf-8". Now all non-JSON-native types are passed through the Encoder, which already calls to_s and handles encoding normalization. Fixes rollbar#1196
waltjones
approved these changes
Jan 8, 2026
waltjones
left a comment
waltjones
left a comment
Contributor
There was a problem hiding this comment.
Looks good , and thank you!
Contributor
|
Released in v3.8.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Rollbar::Encoding.encode only processed String and Symbol types. When objects with to_s methods returning invalid UTF-8 were included in the payload, they bypassed encoding and caused JSON serialization to fail with "source sequence is illegal/malformed utf-8".
Now all non-JSON-native types are passed through the Encoder, which already calls to_s and handles encoding normalization.
Type of change
Related issues
Checklists
Development
Code review