-
Notifications
You must be signed in to change notification settings - Fork 73
[Feat][SDK- 431] Add threads information to payload #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat][SDK- 431] Add threads information to payload #327
Conversation
…chains inside every thread
…ity to use it in RollbarThreadStrategy
@@ -17,38 +19,128 @@ public class RollbarThrowableWrapper implements ThrowableWrapper { | |||
|
|||
private final Throwable throwable; | |||
|
|||
private final Thread thread; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we actually need the Thread
object here, or would the information held by RollbarThread
be sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right, I could just use the RollbarThread here, I'll check it out, thanks!
+ ", stackTraceElements=" + Arrays.toString(stackTraceElements) | ||
+ ", cause=" + cause | ||
+ ", throwable=" + throwable | ||
+ ", thread=" + thread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the expected display value here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something like thread=Thread[main,5,main]
anyway with the other suggestion you made, I'm probably going to change this
Description of the change
We will send information about the status of the threads in the application when sending an exception, whether it is caught or not.
Fields in a Body object
How to test
With any of the test examples we can see this new information in the payload.
Fields in a Thread object
NEW, RUNNABLE, BLOCKED, WAITING, TIMED_WAITING or TERMINATED
In Java we only send 1 TraceChain per Group,
in other languages like Python (ExceptionGroup) or JS (AggregatorError),
it may be more TraceChains per group.
Type of change
Related issues
Checklists
Development
Code review