Skip to content

Conversation

@CodeMan62
Copy link

@CodeMan62 CodeMan62 commented Apr 27, 2025

Description

In this PR we are migration unbuild here and closing #149

Linked Issues

closes #149

Additional context

we already have tsup migration and we are adding unbuild migration here in this PR

@netlify
Copy link

netlify bot commented Apr 27, 2025

Deploy Preview for tsdown ready!

Name Link
🔨 Latest commit c49c784
🔍 Latest deploy log https://app.netlify.com/sites/tsdown/deploys/68107a05f5a5e70008e28a5c
😎 Deploy Preview https://deploy-preview-163--tsdown.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CodeMan62
Copy link
Author

CodeMan62 commented Apr 27, 2025

@sxzz can you tell me how i can add unbuild in package.json because I am bit confuse about it

@CodeMan62 CodeMan62 marked this pull request as ready for review April 28, 2025 09:12
@sxzz
Copy link
Member

sxzz commented Apr 28, 2025

Add unbuild in package.json

"unbuild": "catalog:prod",

And add the version in pnpm-workspace.yaml

catalogs:
  prod:
    unbuild: ^3.5.0

@CodeMan62
Copy link
Author

@sxzz done

@sxzz
Copy link
Member

sxzz commented Apr 29, 2025

I'll covert this PR to draft, since we should modify config file by AST, regex pattern is not enough.

@sxzz sxzz marked this pull request as draft April 29, 2025 07:10
@CodeMan62
Copy link
Author

I'll covert this PR to draft, since we should modify config file by AST, regex pattern is not enough.

let me know if I can help somehow?? i would love to work on it

@CodeMan62
Copy link
Author

@sxzz can you give me a example of config file modified by AST, so I can finish the work for this PR

@sxzz
Copy link
Member

sxzz commented Apr 30, 2025

Sorry, I haven't had time to finish this part yet. Let's postpone the PR for now.

@sxzz sxzz force-pushed the main branch 2 times, most recently from e5e3d73 to 5e77e49 Compare May 3, 2025 21:08
@sxzz sxzz force-pushed the main branch 2 times, most recently from d6772c4 to 4f83186 Compare May 18, 2025 14:32
@sxzz sxzz mentioned this pull request May 24, 2025
@yyx990803
Copy link
Member

yyx990803 commented May 25, 2025

@CodeMan62 thanks a lot for working on this. After some discussion, we decided this is no longer necessary as unbuild now has an official successor. More context in #149

@yyx990803 yyx990803 closed this May 25, 2025
@CodeMan62
Copy link
Author

@yyx990803 no worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unbuild migrate

5 participants