fix: provide correct tests to correspond to reference implementation of binary search#32
Open
gentoosiast wants to merge 1 commit intorolling-scopes-school:masterfrom
Open
fix: provide correct tests to correspond to reference implementation of binary search#32gentoosiast wants to merge 1 commit intorolling-scopes-school:masterfrom
gentoosiast wants to merge 1 commit intorolling-scopes-school:masterfrom
Conversation
|
We need this fix because the old tests are designed for the wrong solution (where we can't reach the lower value of range) |
|
I suffered incredibly for an hour without this correction. It is necessary for the correct algorithm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplied tests fail when reference implementation of binary search is tested against them. By reference implementation I mean binary search algorithm described in Wikipedia:

https://en.wikipedia.org/wiki/Binary_search_algorithm
Another example of reference implementation of binary search algorithm from the book McMillan - Data Structures & Algorithms with JavaScript (2014)

Reference algorithm highlights: