-
-
Notifications
You must be signed in to change notification settings - Fork 11
742-refactor: Update subtitle to support heading tags #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oibioib
wants to merge
24
commits into
main
Choose a base branch
from
refactor/742-update-subtitle-to-support-heading-tags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
de1d4b9
refactor: 742 - update subtitle to support heading tags
oibioib 7b9bb6f
test: 742 - add tests for different heading tags in subtitle
oibioib 882f10c
refactor: 742 - change MentorFeedbackCard
oibioib e148dab
refactor: 742 - change MentorsAfterRegister
oibioib 8efc46c
chore: 742 - merge main
oibioib d633733
chore: 742 - merge main
oibioib d90b767
refactor: 742 - make subtitle props naming consistent
oibioib 97ffee7
refactor: 742 - add subtitle to search component
oibioib 9ddf6eb
refactor: 742 - add subtitle to modal component
oibioib f861e24
refactor: 742 - change modal component styles
oibioib f513af1
refactor: 742 - add subtitle to event-card component
oibioib f67af9f
fix: 742 - add subtitle to event title
oibioib d74bf8a
refactor: 742 - add subtitle to trainer-card component
oibioib 185da33
refactor: 742 - add subtitle to playlist component
oibioib 9757a5f
refactor: 742 - add subtitle to school-menu component
oibioib 1b771cf
fix: 742 - change school-menu line height
oibioib 224fdd2
fix: 742 - change card-subtitle in trainer-card
oibioib cad043b
fix: 742 - add bold style to playlist title
oibioib dc6f3db
refactor: 742 - change subtitle styles classes
oibioib 4f92b13
refactor: 742 - change tests
oibioib 04db309
refactor: 742 - change subtitle order of parameters
oibioib 99de2c3
refactor: 742 - change search gap
oibioib 9f3d2ab
refactor: 742 - trainer card subtitle line-height
oibioib 0adb410
refactor: 742 - change mentor-feedback-card
oibioib File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,10 +98,6 @@ | |
} | ||
} | ||
|
||
.modal-title { | ||
font-size: 20px; | ||
} | ||
|
||
.modal-body { | ||
overflow-y: auto; | ||
padding-bottom: 32px; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change params to
size
&weight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change Subtitle props
fontSize -> size
fontWeight -> weight
?