869-refactor: Update angular mark #875
Conversation
YulikK
requested review from
andron13,
dzmitry-varabei,
SpaNb4,
Quiddlee,
ansivgit and
natanchik
as code owners
github-actions
bot
changed the title
📝 WalkthroughWalkthroughThe changes broaden the Angular course eligibility from only "JS/FE Stage 2" graduates to any RS School course graduates, update related test data, and adjust the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CoursesWidget
participant CourseCard
User->>CoursesWidget: View courses
CoursesWidget->>CourseCard: Render course (with title, subTitle if Angular)
CourseCard-->>CoursesWidget: Course card with conditional subtitle
CoursesWidget-->>User: Displayed course cards with updated eligibility info
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
src/shared/constants.ts (1)
7-7: Add missing Russian translation for the new subtitle constant.We introduced
RS_GRADUATED_ONLY = 'Alumni only'but did not add a corresponding Russian localization. Consider adding anRS_GRADUATED_ONLY_RUconstant or integrating this into the i18n pipeline for consistency across locales.src/widgets/training-program/ui/training-program.test.tsx (1)
12-12: Avoid regex pitfalls in test.The test uses
new RegExp(p, 'i')on a string with punctuation, which can introduce unintended regex behavior. Preferscreen.getByText(p)for exact matching or escape special characters before constructing theRegExp.dev-data/training-program.data.tsx (1)
120-121: Centralize eligibility text.Hardcoding the Angular eligibility description here duplicates the literal. For maintainability, import and render
RS_GRADUATED_ONLYwithin the<Paragraph>instead of repeating the string.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
dev-data/about-course.data.tsx(1 hunks)dev-data/courses.data.ts(2 hunks)dev-data/training-program.data.tsx(1 hunks)src/entities/course/ui/course-card/course-card.test.tsx(1 hunks)src/entities/course/ui/course-card/course-card.tsx(6 hunks)src/shared/constants.ts(1 hunks)src/widgets/courses/ui/courses.test.tsx(2 hunks)src/widgets/training-program/ui/training-program.test.tsx(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
src/widgets/courses/ui/courses.test.tsx (1)
Learnt from: Quiddlee
PR: rolling-scopes/site#572
File: src/pages/home.tsx:25-25
Timestamp: 2024-09-30T12:07:39.137Z
Learning: The `Courses` component in `src/widgets/courses/other-courses.test.tsx`, `src/pages/courses.tsx`, and `dev-data/courses-path.data.ts` is a different component from the one replaced in `src/pages/home.tsx`.
🧬 Code Graph Analysis (2)
dev-data/courses.data.ts (1)
src/shared/constants.ts (3)
RS_GRADUATED_ONLY(7-7)COURSE_LINKS(34-44)TO_BE_DETERMINED(6-6)
src/widgets/courses/ui/courses.test.tsx (1)
src/shared/__tests__/constants.ts (1)
mockedCourses(27-207)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: CI
🔇 Additional comments (11)
dev-data/courses.data.ts (3)
10-10: Good - Import standardizationAdding
RS_GRADUATED_ONLYto imports helps maintain consistency with the new eligibility labeling across the application.
108-108: Good - Broadened eligibility criteriaChanged from hardcoded "JS/FE Stage 2 graduates only" to a more inclusive
RS_GRADUATED_ONLYconstant ('Alumni only'), opening the Angular course to all RS School graduates.
114-114: Good - Using constants for date valuesReplacing hardcoded strings with the
TO_BE_DETERMINEDconstant improves consistency and makes future updates easier.src/widgets/courses/ui/courses.test.tsx (2)
6-6: Good - Using constants for course titlesAdding the
COURSE_TITLESimport allows for more robust title matching in tests.
28-32: Good - Updated test logic for Angular subtitleThe test now correctly handles the special case where Angular course titles include a subtitle suffix in parentheses, ensuring proper test coverage of the UI changes.
src/entities/course/ui/course-card/course-card.tsx (6)
11-11: Good - Using central course title constantsImporting
COURSE_TITLESenables consistent title handling and specific logic for Angular courses.
20-20: Good - Added subTitle property typeProperly extended the type definition to include the subTitle property from Course.
38-38: Good - Destructured subTitle propAdded subTitle to the destructured props to make it available in the component.
56-56: Good - Clean Angular course subtitle logicThe condition to display the Angular course subtitle is clearly defined and handles the special case appropriately.
71-73: Good - Proper subtitle display implementationUpdated the Subtitle component to include the title with optional subtitle suffix for Angular courses.
93-93: Good - Code consolidationConsolidated the ShortInfoPanel component usage to a single line, improving code readability without changing functionality.
|
Lighthouse Report:
|
|
Lighthouse Report:
|
|
Lighthouse Report:
|
|
Lighthouse Report:
|
What type of PR is this? (select all that apply)
Description
Update Angular mark
Related Tickets & Documents
Screenshots, Recordings
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
Our alumni are running to register for the course 🙃
Summary by CodeRabbit