787-feat: Add pagination #888
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeymurDev
requested review from
andron13,
dzmitry-varabei,
SpaNb4,
Quiddlee,
ansivgit and
natanchik
as code owners
TeymurDev
changed the title
|
Please, fix PRs' name |
SpaNb4
reviewed
May 12, 2025
| @@ -25,6 +25,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@next/third-parties": "^15.2.0", | |||
| "antd": "^5.25.0", | |||
There was a problem hiding this comment.
Actually, I'm not sure that we need it
There was a problem hiding this comment.
Colleagues, I think antd is not only one external library in our project. See screenshot below. I can make pagination without antd but then we need to refactor and exclude other external libraries (like swiper) from our project. In other words, we need to decide project with external component libraries or without.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (select all that apply)
Description
Related Tickets & Documents
Screenshots, Recordings
Please replace this line with any relevant images for UI changes.
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?