-
-
Notifications
You must be signed in to change notification settings - Fork 11
830-refactor: Move style params to scss variables #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
run visual now |
@coderabbitai, please create an issue about enforcing variable usage in SCSS, for example using https://github.com/AndyOGo/stylelint-declaration-strict-value |
Tip For best results, initiate chat on the files or code changes. π§© Analysis chainπ Script executed:
Length of output: 1157 π Script executed:
Length of output: 867 π Script executed:
Length of output: 1546 @SpaNb4 I've created a GitHub issue about enforcing variable usage in SCSS using the stylelint-declaration-strict-value plugin as requested. The issue is available at: #895 The issue includes:
|
I can't view the 19 visual changes that require verification. percy returns an error |
Lighthouse Report:
|
Lighthouse Report:
|
π WalkthroughWalkthroughThis update introduces SCSS variables for border radius, font sizes, and spacing gaps in the central style constants file. All hardcoded pixel values for these properties across multiple SCSS modules are replaced with the new variables, standardizing design tokens throughout the codebase without changing layout or logic. Changes
Sequence Diagram(s)Not applicableβno feature or control flow changes. Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π Outside diff range comments (1)
src/shared/ui/subtitle/subtitle.module.scss (1)
47-53
: π οΈ Refactor suggestionReplace hardcoded tablet size with variable
Within the.font-size-extra-large
tablet query,font-size: 32px
should be updated to$font-size-xl
for consistency.- font-size: 32px; + font-size: $font-size-xl;
π§Ή Nitpick comments (7)
src/widgets/numbers/ui/numbers/numbers.module.scss (1)
66-68
: Replace hardcoded gap override with variable
The64px
tablet gap remains hardcoded; consider using an appropriate$gap-*
variable to maintain consistency.src/widgets/merch/ui/merch.module.scss (1)
33-35
: Use SCSS variable for responsive gap
The74px
gap under@include media-laptop
is still hardcoded; consider using a design token (e.g.,$gap-xxxl
) for consistency.src/widgets/breadcrumbs/ui/breadcrumbs.module.scss (1)
5-5
: Consolidate font-size with design tokenGood replacement of the fixed
14px
with$font-size-xs
for consistency.Consider also converting the
8px
horizontal padding in.separator
to$gap-xs
to complete the variable migration.src/shared/ui/main-title/main-title.module.scss (1)
19-19
: Leverage XXL font-size tokenUpdating
44px
to$font-size-xxl
standardizes the small variant typography.Consider migrating other hardcoded sizes (
96px
,60px
) in this file to variables for full consistency.src/widgets/mentorship-activities/ui/mentor-activities/mentor-activities.module.scss (1)
12-12
: Consolidate media queries and variables
Nice use of$gap-s
. Consider merging the two@include media-tablet
blocks into one to reduce duplication.src/widgets/general/ui/general.module.scss (1)
14-14
: Adopt SCSS variable for gap
Great use of$gap-s
. Consider also replacing the hardcodedmargin-top: 24px
(line 23) with a gap variable (e.g.$gap-m
) for full consistency.src/shared/ui/subtitle/subtitle.module.scss (1)
27-33
: Use SCSS variable for base medium size
The medium variant still hardcodes28px
; consider replacing with the appropriate$font-size-xxl
or another token.
π Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
π Files selected for processing (64)
src/app/docs/components/docs-layout/docs-layout.module.scss
(3 hunks)src/app/docs/components/docs-menu/docs-menu.module.scss
(1 hunks)src/app/docs/components/search/search.module.scss
(1 hunks)src/core/styles/_constants.scss
(1 hunks)src/core/styles/index.scss
(2 hunks)src/entities/course/ui/course-card/course-card.module.scss
(5 hunks)src/entities/course/ui/course-item/course-item.module.scss
(1 hunks)src/entities/event/ui/event-card/event-card.module.scss
(6 hunks)src/entities/mentor/ui/mentor-feedback-card/mentor-feedback-card.module.scss
(3 hunks)src/entities/trainer/ui/trainers-card/trainer-card.module.scss
(3 hunks)src/shared/ui/date-simple/date-simple.module.scss
(1 hunks)src/shared/ui/link-custom/link-custom.module.scss
(4 hunks)src/shared/ui/list/list.module.scss
(3 hunks)src/shared/ui/main-title/main-title.module.scss
(1 hunks)src/shared/ui/modal/modal.module.scss
(2 hunks)src/shared/ui/paragraph/paragraph.module.scss
(2 hunks)src/shared/ui/section-label/section-label.module.scss
(1 hunks)src/shared/ui/short-info-panel/short-info-panel.module.scss
(2 hunks)src/shared/ui/social-media-item/social-media-item.module.scss
(2 hunks)src/shared/ui/subtitle/subtitle.module.scss
(3 hunks)src/shared/ui/video-playlist-with-player/playlist/playlist.module.scss
(5 hunks)src/shared/ui/video-playlist-with-player/video-playlist-with-player.module.scss
(2 hunks)src/shared/ui/widget-title/widget-title.module.scss
(3 hunks)src/widgets/about-community/ui/about-community.module.scss
(2 hunks)src/widgets/benefits/ui/benefits/benefits.module.scss
(4 hunks)src/widgets/breadcrumbs/ui/breadcrumbs.module.scss
(1 hunks)src/widgets/community-media/ui/community-media.module.scss
(1 hunks)src/widgets/contribute/ui/contribute.module.scss
(4 hunks)src/widgets/courses/ui/courses.module.scss
(1 hunks)src/widgets/events/ui/events.module.scss
(1 hunks)src/widgets/footer/footer.scss
(2 hunks)src/widgets/general/ui/general.module.scss
(2 hunks)src/widgets/header/ui/nav-item/nav-item.module.scss
(1 hunks)src/widgets/hero-course/ui/hero-course.module.scss
(2 hunks)src/widgets/hero-page/ui/hero-page.module.scss
(2 hunks)src/widgets/mentors-docs/ui/onboard-links/onboard-links.module.scss
(1 hunks)src/widgets/mentors-feedback/ui/mentors-feedback.module.scss
(1 hunks)src/widgets/mentors-register/ui/mentors-register.module.scss
(1 hunks)src/widgets/mentors-wanted-course/ui/mentors-wanted-course.module.scss
(1 hunks)src/widgets/mentors-wanted/ui/mentors-wanted.module.scss
(1 hunks)src/widgets/mentorship-activities/ui/activity-card/activity-card.module.scss
(1 hunks)src/widgets/mentorship-activities/ui/mentor-activities/mentor-activities.module.scss
(1 hunks)src/widgets/mentorship-after-register/ui/mentorship-after-register.module.scss
(1 hunks)src/widgets/mentorship-courses/mentorship-courses.module.scss
(1 hunks)src/widgets/mentorship-details/mentorship-details.module.scss
(1 hunks)src/widgets/mentorship-hero/ui/mentorship-hero.module.scss
(1 hunks)src/widgets/merch/ui/merch.module.scss
(1 hunks)src/widgets/mobile-view/ui/mobile-view.module.scss
(2 hunks)src/widgets/numbers/ui/info-cell/info-cell.module.scss
(3 hunks)src/widgets/numbers/ui/info-grid/info-grid.module.scss
(1 hunks)src/widgets/numbers/ui/numbers/numbers.module.scss
(1 hunks)src/widgets/partnered/partnered.scss
(2 hunks)src/widgets/places/ui/place-item/place-item.module.scss
(2 hunks)src/widgets/principles/ui/principle-card/principle-card.module.scss
(4 hunks)src/widgets/principles/ui/principles/principles.module.scss
(1 hunks)src/widgets/school-menu/ui/school-item/school-item.module.scss
(1 hunks)src/widgets/school-menu/ui/school-menu/school-menu.module.scss
(1 hunks)src/widgets/speakers/ui/speakers.module.scss
(2 hunks)src/widgets/study-path/ui/stage-card/stage-card.module.scss
(4 hunks)src/widgets/study-path/ui/stages/stages.module.scss
(1 hunks)src/widgets/study-with-us/ui/study-with-us.module.scss
(3 hunks)src/widgets/support/ui/support.module.scss
(3 hunks)src/widgets/trainers/ui/trainers.module.scss
(1 hunks)src/widgets/upcoming-courses/ui/upcoming-courses.module.scss
(1 hunks)
π Additional comments (163)
src/core/styles/_constants.scss (3)
99-104
: Add border-radius design tokens. Centralizing border-radius values as SCSS variables enables consistent styling across components.
107-113
: Introduce font-size design tokens. Defining a typographic scale from xx-small to xx-large standardizes text sizing.
116-122
: Centralize gap sizes into SCSS variables. These spacing tokens improve maintainability and ensure consistent layout spacing.src/app/docs/components/docs-menu/docs-menu.module.scss (1)
15-15
: Replace hardcoded font-size with SCSS variable. Using$font-size-xs
aligns this menuβs typography with the projectβs design tokens.src/widgets/school-menu/ui/school-item/school-item.module.scss (1)
67-67
: Standardize description font-size using token. Swapping the fixed12px
for$font-size-xxs
enhances consistency across UI elements.src/shared/ui/section-label/section-label.module.scss (1)
4-4
: Use SCSS variable for label font-size. Replacing14px
with$font-size-xs
ensures uniform text sizing.src/widgets/mentorship-courses/mentorship-courses.module.scss (1)
8-8
: Adopt SCSS variable for grid gap. Replacing32px
with$gap-xl
improves maintainability and aligns with design tokens.src/app/docs/components/search/search.module.scss (1)
45-47
: Use SCSS variable for font size
Replaced hardcoded14px
with$font-size-xs
to align with design tokens.src/widgets/numbers/ui/numbers/numbers.module.scss (1)
4-7
: Use SCSS gap variable
Replaced24px
with$gap-l
for consistent spacing.src/widgets/study-path/ui/stages/stages.module.scss (1)
1-5
: Centralize spacing with SCSS variable
Updatedgap
to$gap-xl
instead of32px
to align with design system tokens.src/widgets/merch/ui/merch.module.scss (1)
1-3
: Standardize layout gap
Replaced hardcoded50px
with$gap-xxxl
for unified spacing.src/widgets/header/ui/nav-item/nav-item.module.scss (1)
50-53
: Use SCSS font-size variable
Replaced16px
with$font-size-s
to unify typography scales.src/entities/course/ui/course-item/course-item.module.scss (1)
25-25
: Consistent spacing: use SCSS gap variable
Replacing the hardcoded gap with$gap-xs
aligns this component with the design tokens and improves maintainability.src/widgets/upcoming-courses/ui/upcoming-courses.module.scss (1)
19-19
: Consistent spacing: use SCSS gap variable
Swapping the fixed24px
for$gap-l
standardizes spacing according to the design system.src/widgets/numbers/ui/info-grid/info-grid.module.scss (1)
44-44
: Consistent spacing: use SCSS gap variable
Replacing the hardcoded24px
gap with$gap-l
ensures uniform spacing across responsive breakpoints.src/widgets/trainers/ui/trainers.module.scss (1)
8-8
: Consistent spacing: use SCSS gap variable
Using$gap-xl
instead of a fixed32px
keeps this grid in line with our spacing scale.src/widgets/mentors-feedback/ui/mentors-feedback.module.scss (1)
4-4
: Consistent spacing: use SCSS gap variable
Switching from32px
to$gap-xl
here improves consistency with the global gap definitions.src/shared/ui/date-simple/date-simple.module.scss (2)
3-3
: Use standardized gap variableReplacing the hardcoded
8px
with$gap-xs
ensures consistent spacing across components.
9-9
: Apply font-size design tokenSwitching
14px
to$font-size-xs
aligns typography with the global style system.src/widgets/events/ui/events.module.scss (2)
4-4
: Standardize large gap spacingGood use of
$gap-l
to replace the previous24px
gap.
10-10
: Standardize small gap spacingReplacing
16px
with$gap-s
ensures uniform spacing tokens.src/widgets/principles/ui/principles/principles.module.scss (3)
3-3
: Apply XL gap tokenThe default
gap
is now standardized to$gap-xl
.
8-8
: Apply S gap token for laptopSwitching to
$gap-s
aligns laptop layout spacing.
13-13
: Apply XS gap token for tabletUsing
$gap-xs
ensures tighter spacing on tablets per design.src/widgets/mentors-wanted-course/ui/mentors-wanted-course.module.scss (1)
28-28
: Use SCSS variable for gap Replaced hardcoded spacing with$gap-xxl
under the tablet breakpoint for consistency.src/widgets/mentorship-hero/ui/mentorship-hero.module.scss (1)
14-14
: Apply design token for border radius Swapped the fixed12px
radius with$border-radius-s
to align with the style constants.src/widgets/mentorship-activities/ui/activity-card/activity-card.module.scss (2)
4-4
: Use SCSS variable for gap Updated the flex gap to$gap-s
instead of a hardcoded value.
9-9
: Use SCSS variable for border radius Swapped the hardcoded corner rounding with$border-radius-s
.src/widgets/mentors-wanted/ui/mentors-wanted.module.scss (1)
21-21
: Use SCSS variable for gap Replaced the fixed40px
gap with$gap-xxl
under the large-tablet breakpoint.src/widgets/mentorship-details/mentorship-details.module.scss (1)
7-7
: Use SCSS variable for gap Converted the static gap to$gap-xxl
for design consistency.src/widgets/mentors-docs/ui/onboard-links/onboard-links.module.scss (2)
6-6
: Standardize font-size with SCSS variable
Nice replacement of hardcoded18px
with$font-size-m
. This centralizes typography tokens.
10-10
: Use SCSS variable for responsive font-size
Good swap of16px
to$font-size-s
in the laptop breakpoint.src/widgets/mentorship-activities/ui/mentor-activities/mentor-activities.module.scss (1)
5-5
: Replace hardcoded gap with SCSS variable
gap: 32px
β$gap-xl
ensures consistent spacing tokens across your grid layout.src/widgets/community-media/ui/community-media.module.scss (2)
3-3
: Use design token for large gap
Replacing50px
with$gap-xxxl
improves theme consistency.
7-7
: Swap fixed gap for SCSS variable
16px
β$gap-s
aligns with your spacing scale.src/widgets/general/ui/general.module.scss (1)
5-5
: Convert column-gap to SCSS variable
column-gap: 24px
β$gap-l
centralizes spacing configuration.src/widgets/mentors-register/ui/mentors-register.module.scss (2)
13-13
: Verify spacing variable matches original value
Confirm that$gap-xxxl
maps to the previous176px
so this refactor doesnβt unintentionally alter the layout.
18-18
: Replace fixed gap with SCSS variable
Switching32px
to$gap-xl
keeps the spacing scale coherent.src/shared/ui/widget-title/widget-title.module.scss (3)
14-14
: Adopted XXL font-size variable for.small
.
Great replacement of the hardcodedfont-size
with$font-size-xxl
, ensuring consistency with design tokens.
26-26
: Standardized tablet font-size in.medium
.
Using$font-size-xxl
under the tablet media query aligns with the new style constants.
38-38
: Standardized tablet font-size in.large
.
Substituted the fixed value with$font-size-xxl
for consistency at tablet breakpoints.src/widgets/mobile-view/ui/mobile-view.module.scss (2)
14-14
: Replaced hardcoded gap with$gap-s
.
Applying$gap-s
improves thematic spacing consistency across components.
38-38
: Replaced hardcoded font-size with$font-size-l
.
Switching to the SCSS variable ensures maintainable typography scales.src/widgets/partnered/partnered.scss (2)
7-7
: Replaced hardcoded title size with$font-size-xxl
.
Consistent use of the new font-size variable keeps typography in sync.
37-37
: Replaced hardcoded row-gap with$gap-s
.
Using the$gap-s
token standardizes vertical spacing under the tablet mixin.src/widgets/courses/ui/courses.module.scss (1)
4-4
: Replaced fixed gap with$gap-l
.
Adopting the$gap-l
variable aligns this layout with global spacing tokens.src/widgets/school-menu/ui/school-menu/school-menu.module.scss (2)
6-6
: Replaced hardcoded gap with$gap-s
.
Switching to the$gap-s
variable ensures consistent spacing in the menu layout.
11-11
: Replaced fixed font-size with$font-size-xxs
.
Using$font-size-xxs
improves consistency and maintainability of text sizing.src/widgets/hero-page/ui/hero-page.module.scss (2)
2-2
: Verify$gap-s
availability: Ensure_constants.scss
is imported or$gap-s
is globally available to avoid compilation errors.
30-30
: Approve font-size variable: Using$font-size-xl
here aligns with the global typography scale.src/core/styles/index.scss (2)
134-134
: Verify$border-radius-xs
import: Confirm that the constants file providing$border-radius-xs
is loaded in this context.
208-208
: Approve font-size variable: Substituting24px
with$font-size-xl
standardizes your heading sizes.src/widgets/hero-course/ui/hero-course.module.scss (3)
7-7
: Verify$gap-xxl
import: Ensure the new extra-large gap token is defined and available in this module.
24-24
: Approve hero-subtitle font size:$font-size-xl
is consistent with other subtitle scales.
29-29
: Approve tablet font size:$font-size-l
fits the responsive design spec.src/widgets/about-community/ui/about-community.module.scss (3)
8-8
: Verify$gap-m
import: Confirm that the medium gap variable is defined and imported correctly.
28-28
: Approve extra-large gap variable: Replacing176px
breakpoints with$gap-xxxl
improves consistency.
32-32
: Approve large gap variable: Using$gap-xl
here aligns with the layout spacing guidelines.src/app/docs/components/docs-layout/docs-layout.module.scss (3)
34-34
: Approve menu gap variable:$gap-m
standardizes spacing in the mobile menu layout.
43-43
: Approve content gap variable: Using$gap-xxxl
here aligns with the global spacing scale.
62-62
: Approve top section gap: Substituting20px
with$gap-m
ensures responsive consistency.src/shared/ui/video-playlist-with-player/video-playlist-with-player.module.scss (2)
4-4
: Standardize gap using design token
Replacing the hardcoded value with$gap-l
aligns with our spacing scale.
18-18
: Standardize border-radius using design token
Using$border-radius-s
ensures consistent rounding across components.src/widgets/numbers/ui/info-cell/info-cell.module.scss (3)
7-7
: Standardize gap using design token
Switching to$gap-s
centralizes spacing control and improves maintainability.
49-49
: Standardize title font-size using design token
Applying$font-size-xxl
aligns typography with our scale.
74-74
: Standardize description font-size using design token
Using$font-size-s
ensures consistent text sizing.src/shared/ui/modal/modal.module.scss (2)
9-9
: Standardize border-radius using design token
Replacing12px
with$border-radius-s
maintains consistency with our radius scale.
120-122
: Standardize close-button styling using design tokens
Switching to$border-radius-xxxl
and$font-size-xl
ensures uniform look & feel.src/widgets/mentorship-after-register/ui/mentorship-after-register.module.scss (5)
4-4
: Standardize gap using design token
Applying$gap-m
centralizes vertical spacing.
9-9
: Standardize steps gap using design token
Using$gap-xxl
aligns section spacing with our design system.
14-14
: Standardize step gap using design token
Replacing hardcoded gap with$gap-s
enhances spacing consistency.
21-21
: Standardize tablet step gap using design token
Switching to$gap-xs
ensures responsive spacing scales correctly.
26-26
: Standardize tablet steps gap using design token
Using$gap-l
maintains consistent responsive spacing.src/widgets/study-path/ui/stage-card/stage-card.module.scss (5)
3-3
: Standardize card gap using design token
Setting gap to$gap-xxl
aligns layout spacing with our scale.
25-25
: Standardize step font-size using design token
Updating to$font-size-xl
ensures consistent typography.
33-33
: Standardize step font-size for tablet using design token
Switching to$font-size-s
maintains responsive font scaling.
52-52
: Standardize stage-info gap using design token
Replacing with$gap-xs
centralizes content spacing.
106-106
: Standardize responsive card gap using design token
Applying$gap-s
ensures uniform spacing on tablet.src/shared/ui/short-info-panel/short-info-panel.module.scss (3)
4-4
: Consistent gap token:
Replacing16px
with$gap-s
aligns with the centralized spacing scale.
14-14
: Tight gap token:
Using$gap-xs
instead of8px
keeps small gutters consistent.
20-20
: Small font-size token:
Switching14px
to$font-size-xs
enforces your new typographic scale.src/widgets/places/ui/place-item/place-item.module.scss (3)
8-8
: Medium font-size token:
Changing20px
to$font-size-l
standardizes heading text sizes.
22-22
: Extra-large font-size token:
Replacing36px
with$font-size-xxl
matches the design system.
27-27
: Responsive font-size token:
Using$font-size-s
in the tablet breakpoint keeps typography consistent.src/shared/ui/list/list.module.scss (4)
4-4
: List gap token:
Swapping8px
for$gap-xs
aligns list spacing with the new scale.
6-6
: Base font-size token:
Replacing18px
with$font-size-m
ensures consistent body text sizing.
16-16
: Compact variant font-size token:
Using$font-size-s
in the laptop media query matches your responsive typographic rules.
26-26
: Responsive font-size token:
Switching16px
to$font-size-s
for tablet-large preserves typographic consistency.src/widgets/study-with-us/ui/study-with-us.module.scss (6)
4-4
: Large gap token:
Changing24px
to$gap-l
standardizes vertical rhythm in the main container.
12-12
: Triple-extra-large gap token:
Replacing?px
(assumed original) with$gap-xxxl
in.study-wrap
ensures consistency.
15-16
: Double-extra-large responsive gap:
Swapping?px
to$gap-xxl
in tablet-large breakpoint maintains the design tokens.
45-45
: Consistent gap token in options:
Using$gap-l
instead of a fixed value aligns the option list with the new spacing scale.
51-51
: Responsive extra-large gap in options:
Switching to$gap-xl
for tablet-large reinforces your responsive layout tokens.
62-62
: Small gap token in item:
Replacing the hardcoded gap with$gap-s
ensures uniform item spacing.src/widgets/footer/footer.scss (4)
22-22
: Footer about-list gap token:
Using$gap-l
instead of24px
keeps list spacing on-brand.
26-26
: Footer about-list font-size token:
Replacing18px
with$font-size-m
aligns with global typography settings.
56-56
: Responsive footer gap token:
Switching50px
to$gap-xxxl
in the laptop-medium breakpoint ensures token consistency.
59-59
: Footer left section gap token:
Using$gap-xxxl
matches the updated spacing scale in the breakpoint.src/shared/ui/social-media-item/social-media-item.module.scss (3)
6-6
: Use design tokens for spacing Replacing hardcoded8px
with$gap-xs
aligns with the centralized gap scale.
13-13
: Use design tokens for typography Substituting14px
with$font-size-xs
maintains consistency in the type scale.
48-48
: Use responsive type tokens Switching12px
to$font-size-xxs
in the tablet media query keeps the font-size scale uniform.src/entities/mentor/ui/mentor-feedback-card/mentor-feedback-card.module.scss (4)
4-4
: Standardize gap value Changinggap: 24px
to$gap-l
ensures consistent spacing across components.
11-11
: Use border-radius token Replacing12px
with$border-radius-s
centralizes corner rounding.
39-39
: Standardize gap value Updatinggap: 24px
to$gap-l
in.card-info
aligns with the design system.
57-57
: Standardize gap value Applying$gap-l
instead of24px
in.card-content-wrapper
keeps spacing uniform.src/widgets/contribute/ui/contribute.module.scss (4)
4-4
: Standardize gap value Replacinggap: 24px
with$gap-l
centralizes spacing definitions.
36-36
: Standardize gap value Changinggap: 50px
to$gap-xxxl
aligns with the global gap scale.
46-46
: Standardize gap value Swappinggap: 24px
for$gap-l
in.contribute-options
keeps spacing consistent.
61-61
: Standardize gap value Updatinggap: 16px
to$gap-s
in.option-item
adheres to the spacing tokens.src/widgets/speakers/ui/speakers.module.scss (4)
3-3
: Standardize gap value Replacing50px
with$gap-xxxl
ensures uniform spacing across the.speakers
layout.
15-15
: Standardize gap value Changinggap: 8px
to$gap-xs
in.email-wrapper
aligns with the gap scale.
19-19
: Use design tokens for typography Substituting18px
with$font-size-m
maintains the type scale in.email-wrapper
.
24-24
: Use responsive type tokens Switching16px
to$font-size-s
in the tablet media query ensures responsive typography.src/widgets/support/ui/support.module.scss (5)
5-5
: Standardize gap value Replacing50px
with$gap-xxxl
in.support-content
aligns with the global spacing scale.
40-40
: Standardize gap value Changinggap: 16px
to$gap-s
in.donate-options
keeps spacing consistent.
48-48
: Standardize gap value Swappinggap: 24px
for$gap-l
in.donate-item
adheres to the design tokens.
51-51
: Use responsive spacing token Updatinggap: 16px
to$gap-s
in the tablet media query ensures consistent spacing.
62-62
: Use responsive spacing token Replacing40px
with$gap-xxl
in the tablet-large media query aligns with spacing tokens.src/shared/ui/subtitle/subtitle.module.scss (2)
5-13
: Verify font-size mapping for extra-small
The.font-size-extra-small
class uses$font-size-l
at base and$font-size-m
at tablet; please confirm this mapping aligns with design guidelines.
16-23
: Verify font-size mapping for small
.font-size-small
applies$font-size-xl
(base) and$font-size-l
(tablet); ensure this matches project design tokens.src/widgets/benefits/ui/benefits/benefits.module.scss (6)
13-17
: Grid-item uses SCSS variables correctly
The.grid-item
now leverages$border-radius-s
and$font-size-m
, replacing hardcoded values.
38-42
: Used$gap-l
in laptop breakpoint
The media-laptop query replaces the fixedgap
with$gap-l
, aligning with the design tokens.
44-46
: Applied$gap-s
for tablet breakpoint
The media-tablet query now uses$gap-s
instead of a literal value.
61-69
: Flex-item styling tokens applied
Flex items now use$gap-s
,$border-radius-s
, and$font-size-m
, improving consistency.
92-95
: Laptop breakpoint flex gap
The flex layoutβs laptop media query correctly uses$gap-l
.
97-100
: Tablet breakpoint flex gap
The flex layoutβs tablet media query now leverages$gap-s
.src/entities/course/ui/course-card/course-card.module.scss (5)
11-14
: Use SCSS variable for base card border-radius
The root.course-card
now uses$border-radius-s
, replacing hardcoded radius.
36-42
: Apply design tokens in card-header
.card-header
βsgap
and top border-radius now utilize$gap-s
and$border-radius-s
.
60-68
: Consistent styling tokens in course-info
.course-info
uses$gap-s
and$border-radius-s
for spacing and corner rounding.
103-106
: Size-sm variant uses$font-size-xs
The.size-sm .course-info
now employs$font-size-xs
instead of hardcoded text size.
119-121
: Size-sm course-link font-size token
The.size-sm .course-link
now references$font-size-xs
for readability consistency.src/shared/ui/link-custom/link-custom.module.scss (4)
6-9
: Button gap variable applied
The.button
class now uses$gap-xs
for spacing, replacing the hardcoded8px
.
17-23
: Secondary variant font-size token
.secondary
now uses$font-size-m
instead of18px
, improving consistency.
39-46
: Primary variant font-size standardization
.primary
applies$font-size-m
for its text size, aligning with the design system.
63-68
: Rounded variant uses design tokens
.rounded
now references$border-radius-xxxl
and$font-size-xs
, removing magic numbers.src/entities/trainer/ui/trainers-card/trainer-card.module.scss (5)
1-4
: Apply gap token to trainer-card
The root.trainer-card
now uses$gap-l
for spacing instead of a fixed24px
.
7-10
: Use variable for card border-radius
.trainer-card
container corners now reference$border-radius-m
, improving theme consistency.
19-21
: Card-picture image rounding token
Inner image now uses$border-radius-s
, removing the hardcoded radius.
31-36
: Consistent font-size for subtitle
.card-subtitle
now applies$font-size-m
rather than a literal18px
.
39-42
: Standardize content font-size
.card-content
text now uses$font-size-s
, replacing the previous hardcoded size.src/widgets/principles/ui/principle-card/principle-card.module.scss (6)
1-115
: Re-run visual regression tests.Percy reported errors previously; ensure these refactors render correctly across breakpoints.
9-9
: Standardize column gap with$gap-s
.Replacing
16px
with the design token ensures consistent spacing.
14-14
: Use$border-radius-s
for rounded corners.Applying the SCSS variable centralizes border-radius values.
35-35
: Adopt$gap-s
for flex gap.This aligns
card-header
spacing with the global spacing scale.
51-51
: Normalize body text size with$font-size-m
.Switching
18px
to the font-size variable maintains typographic consistency.
110-110
: Adjust narrow viewport text with$font-size-s
.Replacing
16px
insidemedia-laptop
improves maintainability.src/entities/event/ui/event-card/event-card.module.scss (6)
8-8
: Use$border-radius-s
on the card container.Centralizing corner radius ensures uniform components.
19-19
: Apply$border-radius-s
to header corners.This variable replacement maintains consistency with other cards.
41-41
: Switch.event-tag
font-size to$font-size-s
.Using the font token aligns text size across UI elements.
76-76
: Refactor.event-additional-info
font to$font-size-s
.The SCSS variable standardizes the small text size.
95-95
: Set footer border radius via$border-radius-s
.Ensures the bottom corners match the top radius.
107-107
: Use$font-size-xs
for event-date text.Replaces fixed
14px
to keep typographic scale.src/shared/ui/paragraph/paragraph.module.scss (4)
8-8
: Define.medium-font-size
with$font-size-m
.Standardizing the medium paragraph size improves consistency.
14-14
: Use$font-size-l
for.large-font-size
.Aligns large paragraphs with the global typographic scale.
26-26
: Apply$font-size-s
insidemedia-laptop
.Consistent small text sizing in responsive layouts.
31-31
: Normalize large text on laptop with$font-size-m
.Replaces fixed value for maintainability.
src/shared/ui/video-playlist-with-player/playlist/playlist.module.scss (7)
4-4
: Adopt$gap-xs
for playlist gap.Switching from
8px
to the spacing token unifies layout.
13-13
: Use$gap-xs
in.videos-container
.Consistent small gap across the playlist items.
18-18
: Switch to$gap-l
on larger breakpoints.Replaces
24px
with the large spacing variable.
37-37
: Apply$gap-xs
for.playlist-item
gap.Ensures item spacing follows the design token scale.
69-69
: Define thumbnail border radius with$border-radius-xs
.Centralizes the small corner radius value.
91-91
: Use$border-radius-xs
for overlay rounding.Maintains consistent small-radius styling.
93-93
: Standardize overlay text size with$font-size-xs
.Replaces
14px
to match the typography scale.
What type of PR is this? (select all that apply)
Description
Related Tickets & Documents
Screenshots, Recordings
Please replace this line with any relevant images for UI changes.
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
Summary by CodeRabbit