887-refactor: Partners refactor #892
Conversation
github-actions
bot
changed the title
|
Lighthouse Report:
|
|
Lighthouse Report:
|
|
Lighthouse Report:
|
src/widgets/partnered/partnered.tsx
Outdated
| <WidgetTitle size="small">Partnered with</WidgetTitle> | ||
| <div className="partners"> | ||
| <div className="partner-logo-container"> | ||
| <ul className={cx('partners')}> |
There was a problem hiding this comment.
Could we use the structure like in Alumni widget?
There was a problem hiding this comment.
I understand a point of keeping a similar HTML structure in all our widgets
Difference for now:
Alumni
<article>
<section>
<WidgetTitle />
<Paragraph />
<section>
{alumni.map(() => (
<figure>
<Image />
</figure>
))}
</section>
</section>
</article>
Partnered
<section>
<div>
<WidgetTitle />
<ul>
{partners.map(() => (
<li>
<Component />
</li>
))}
</ul>
</div>
</section>
- All containers in widgets have
sectiontag. - I't strange to have
article->section->sectionstructure - lists usually use
ul->litags
Therefore, I suggest to keep partnered html structure in both partnered and alumni widgets
|
Lighthouse Report:
|
|
👍 |
HelenaIsh
requested review from
andron13,
dzmitry-varabei,
SpaNb4,
Quiddlee and
natanchik
as code owners
📝 WalkthroughWalkthroughThe changes restructure the partnered widget by moving logic and styles into a new FSD-compliant folder structure, updating the HTML for semantic correctness, and introducing a constants file for partners. Test coverage and styling are migrated to new module-based files, and test IDs are added to logo components for improved testing. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PartneredComponent
participant WidgetTitle
participant PartnersConstants
participant LogoComponent
User->>PartneredComponent: Render
PartneredComponent->>WidgetTitle: Render "Partnered with"
PartneredComponent->>PartnersConstants: Retrieve partners array
loop For each partner
PartneredComponent->>LogoComponent: Render logo
end
Assessment against linked issues
Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Lighthouse Report:
|
What type of PR is this? (select all that apply)
Description
Refactor partnered module
Related Tickets & Documents
Screenshots, Recordings
I changed a little bit styles for tablets and mobiles
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
Summary by CodeRabbit
New Features
Style
Bug Fixes
Tests
Chores