-
-
Notifications
You must be signed in to change notification settings - Fork 11
876-fix: Update paddings for wide screens #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
π WalkthroughWalkthroughA new SCSS mixin for desktop-wide media queries was introduced. The headerβs Changes
Sequence Diagram(s)sequenceDiagram
participant Browser
participant SCSS
participant Header
participant Footer
Browser->>SCSS: Render styles
SCSS->>Header: Apply .navbar-content max-width (1280px) if >$content-width
SCSS->>Footer: Apply .footer.content padding (40px 80px)
Assessment against linked issues
Note β‘οΈ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note β‘οΈ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Nitpick comments (1)
src/widgets/header/header.module.scss (1)
49-52
: Cap.navbar-content
on very wide screens - Great use of the newmedia-desktop-wide
mixin to limit the header to1280px
past the main content width. Consider extracting the hardcoded1280px
into a SCSS variable (e.g.,$wide-desktop-width
) for consistency and easier updates.
π Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
π Files selected for processing (3)
src/core/styles/_mixins.scss
(1 hunks)src/widgets/footer/footer.scss
(1 hunks)src/widgets/header/header.module.scss
(1 hunks)
π Additional comments (2)
src/core/styles/_mixins.scss (1)
39-43
: Newmedia-desktop-wide
mixin - The mixin correctly wraps nested styles in amin-width: $content-width + 1px
media query, matching the project's breakpoint conventions.src/widgets/footer/footer.scss (1)
5-5
: Reduced horizontal padding for.footer.content
- Lowering the side padding from120px
to80px
brings the footer in line with the main content width on large viewports.
What type of PR is this? (select all that apply)
Description
Aligned header and footer with main content on large screens (>1440px):
Related Tickets & Documents
Screenshots, Recordings
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
Summary by CodeRabbit