Skip to content

876-fix: Update paddings for wide screens #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gbogdanova
Copy link
Collaborator

@gbogdanova gbogdanova commented May 13, 2025

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Aligned header and footer with main content on large screens (>1440px):

  • introduced a media-desktop-wide mixin for targeting screens wider than 1440px
  • updated header.module.scss to limit the header's width according to the content width
  • reduced horizontal padding in the footer to match the main content alignment

Related Tickets & Documents

Screenshots, Recordings

Screenshot 2025-05-13 at 4 21 38β€―PM

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

ruler

Summary by CodeRabbit

  • Style
    • Reduced horizontal padding in the footer for a more compact layout.
    • Adjusted the maximum width of the header navigation bar on wide desktop screens for improved appearance on larger displays.

@github-actions github-actions bot changed the title Fix/876 update paddings for wide screens 876-fix: Update paddings for wide screens May 13, 2025
@gbogdanova gbogdanova requested a review from SpaNb4 May 15, 2025 16:51
@SpaNb4 SpaNb4 marked this pull request as ready for review May 15, 2025 17:51
Copy link
Contributor

coderabbitai bot commented May 15, 2025

πŸ“ Walkthrough

Walkthrough

A new SCSS mixin for desktop-wide media queries was introduced. The header’s .navbar-content now limits its max-width to 1280px on wide screens, and the footer’s horizontal padding was reduced. These changes adjust layout consistency for large viewports.

Changes

File(s) Change Summary
src/core/styles/_mixins.scss Added media-desktop-wide mixin for styles targeting viewports wider than $content-width.
src/widgets/footer/footer.scss Reduced .footer.content horizontal padding from 120px to 80px.
src/widgets/header/header.module.scss Applied new media query: set .navbar-content max-width to 1280px for wide desktops.

Sequence Diagram(s)

sequenceDiagram
    participant Browser
    participant SCSS
    participant Header
    participant Footer

    Browser->>SCSS: Render styles
    SCSS->>Header: Apply .navbar-content max-width (1280px) if >$content-width
    SCSS->>Footer: Apply .footer.content padding (40px 80px)
Loading

Assessment against linked issues

Objective Addressed Explanation
Update paddings and widths for menu, content, and footer on screens >1440px (#876) βœ…

Note

⚑️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚑️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boostβ€”your workflow just got faster.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/widgets/header/header.module.scss (1)

49-52: Cap .navbar-content on very wide screens - Great use of the new media-desktop-wide mixin to limit the header to 1280px past the main content width. Consider extracting the hardcoded 1280px into a SCSS variable (e.g., $wide-desktop-width) for consistency and easier updates.

πŸ“œ Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between e3a4b26 and 813da24.

πŸ“’ Files selected for processing (3)
  • src/core/styles/_mixins.scss (1 hunks)
  • src/widgets/footer/footer.scss (1 hunks)
  • src/widgets/header/header.module.scss (1 hunks)
πŸ”‡ Additional comments (2)
src/core/styles/_mixins.scss (1)

39-43: New media-desktop-wide mixin - The mixin correctly wraps nested styles in a min-width: $content-width + 1px media query, matching the project's breakpoint conventions.

src/widgets/footer/footer.scss (1)

5-5: Reduced horizontal padding for .footer.content - Lowering the side padding from 120px to 80px brings the footer in line with the main content width on large viewports.

@gbogdanova gbogdanova self-assigned this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to update paddings on screen over 1440px
2 participants