Skip to content

897-fix: Remove repeated footer sections #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gbogdanova
Copy link
Collaborator

@gbogdanova gbogdanova commented May 15, 2025

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

  • Hid DesktopView at ≀1024px to eliminate footer duplication and ensure it switches to MobileView in sync with the header

  • Removed redundant DesktopView styles in the media-tablet-large breakpoint

Related Tickets & Documents

Screenshots, Recordings

Screenshot 2025-05-15 at 12 50 42β€―PM

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Summary by CodeRabbit

  • Style
    • Updated responsive behavior for the footer: the .desktop-view element is now hidden at larger tablet screen sizes, and certain layout adjustments for .desktop-view and its children were removed for improved consistency across devices.

@github-actions github-actions bot changed the title Fix/897 remove repeated footer sections 897-fix: Remove repeated footer sections May 15, 2025
@YulikK YulikK added this to RS Site May 15, 2025
@YulikK YulikK moved this to Review in RS Site May 15, 2025
@YulikK YulikK added bug Something isn't working high priority labels May 15, 2025
Copy link

Lighthouse Report:

  • Performance: 72 / 100
  • Accessibility: 96 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@gbogdanova gbogdanova marked this pull request as ready for review May 16, 2025 16:38
Copy link
Contributor

coderabbitai bot commented May 16, 2025

πŸ“ Walkthrough

Walkthrough

The .desktop-view footer element is now hidden at the media-tablet-large breakpoint instead of media-tablet. Additionally, styles specific to the media-tablet-large breakpoint for .desktop-view and its .left child have been removed.

Changes

File(s) Change Summary
src/widgets/footer/footer.scss Changed media query for hiding .desktop-view from media-tablet to media-tablet-large. Removed block of styles under media-tablet-large affecting .desktop-view and its .left child.

Assessment against linked issues

Objective Addressed Explanation
Remove repeated Footer sections for viewports between 810px and 1024px (#897) βœ…

Note

⚑️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚑️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boostβ€”your workflow just got faster.


πŸ“œ Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 9edc92c and 65845ba.

πŸ“’ Files selected for processing (1)
  • src/widgets/footer/footer.scss (1 hunks)
πŸ”‡ Additional comments (2)
src/widgets/footer/footer.scss (2)

51-53: Breakpoint update hides DesktopView at the correct width
Switching the hide rule to @include media-tablet-large ensures the desktop footer is hidden at ≀1024px, keeping it in sync with the header and resolving the duplicate footer issue (#897).


51-53:

βœ… Verification successful

Verify media-tablet-large mixin semantics
Please confirm that media-tablet-large targets a max-width of 1024px (not a min-width) so the .desktop-view is indeed hidden on smaller screens. You can locate the mixin definition with:


🏁 Script executed:

#!/bin/bash
# Locate media-tablet-large mixin to verify its breakpoint
rg -A3 "@mixin media-tablet-large" .

Length of output: 252


To confirm the exact breakpoint value, let’s locate the $large-tablet-width variable definition:


🏁 Script executed:

#!/bin/bash
# Find where $large-tablet-width is defined
rg -n '\$large-tablet-width' .

Length of output: 175


Confirmed: media-tablet-large applies a max‐width of 1024px

  • src/core/styles/_mixins.scss: @mixin media-tablet-large { @media (max-width: $large-tablet-width) { … } }
  • src/core/styles/_constants.scss: $large-tablet-width: 1024px;

No changes neededβ€”.desktop-view will be hidden on screens ≀1024px.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KristiBo KristiBo removed this from RS Site May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove repeated Footer sections for viewports between 810px and 1024px
4 participants