feat(update.sh): remove old kernels script, keep latest and latest mainline.#71
Open
washran wants to merge 1 commit into
Open
feat(update.sh): remove old kernels script, keep latest and latest mainline.#71washran wants to merge 1 commit into
washran wants to merge 1 commit into
Conversation
Contributor
|
Will review shortly. |
ajstrongdev
requested changes
Aug 1, 2022
ajstrongdev
left a comment
ajstrongdev
left a comment
Contributor
There was a problem hiding this comment.
@washran your PR is utilising an old fork with outdated code such as utilising the 5.18.0 kernel, please update this immediately.
Contributor
|
Will review the rest of the code once this has been rectified. |
Contributor
|
Closing in 14 days if changes are not made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of piling up kernels and not trimming them, we need to keep latest working kernel and latest mainline kernel. An example code is listed here... https://askubuntu.com/questions/1253347/how-to-easily-remove-old-kernels-in-ubuntu-20-04-lts ... The code needs work, I believe