Skip to content

chore: bump latest rollkit #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

chore: bump latest rollkit #115

merged 1 commit into from
May 26, 2025

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented May 26, 2025

Overview

Includes latest breaking change.

Summary by CodeRabbit

  • Chores
    • Updated several dependencies to newer versions for improved stability and compatibility.

Copy link
Contributor

coderabbitai bot commented May 26, 2025

Walkthrough

The changes update several dependencies in go.mod, specifically upgrading the rollkit modules and go-header to newer versions. In server/start.go, the *nodeKey argument is removed from the call to node.NewNode within the node setup function, altering the node initialization process.

Changes

File(s) Change Summary
go.mod Updated rollkit and go-header dependencies to newer versions and commits.
server/start.go Removed the *nodeKey argument from the node.NewNode call in the node setup function.

Sequence Diagram(s)

sequenceDiagram
    participant Server
    participant Node
    participant NodeKey

    Server->>Node: NewNode(..., /* nodeKey removed */, ...)
    Note right of Node: Node initializes without explicit nodeKey argument
Loading

Possibly related PRs

Suggested reviewers

  • gupadhyaya

Poem

A hop and a skip, dependencies rise,
With rollkit renewed and headers revised.
The nodeKey now rests, no longer in tow,
As the server starts up, ready to go.
In the warren of code, changes abound—
New paths for the rabbits, new secrets to be found! 🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b9c4db1 and 6d5d31f.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod (2 hunks)
  • server/start.go (0 hunks)
💤 Files with no reviewable changes (1)
  • server/start.go
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: lint / golangci-lint
  • GitHub Check: test / Run Unit Tests
  • GitHub Check: Test with Rollkit Chain
🔇 Additional comments (2)
go.mod (2)

78-78: Approve indirect bump of go-header
The github.com/celestiaorg/go-header indirect dependency has been updated to v0.6.6. This minor bump is unlikely to introduce breaking changes, so it looks good.


30-33:

❓ Verification inconclusive

Verify rollkit dependency bump
The rollkit modules (rollkit, core, da, sequencers/single) have been updated to v0.14.2-0.20250526094218-4a5686055970. Ensure this pseudo-version corresponds to the intended commit/branch and that any breaking changes in the new version have been addressed in your code.

Run this script to confirm only these versions are present in the module graph:


🏁 Script executed:

#!/bin/bash
# Verify updated rollkit module versions in the build
set -e
go list -m all | rg '^github\.com/rollkit/rollkit(@| )'
go list -m all | rg '^github\.com/rollkit/rollkit/core(@| )'
go list -m all | rg '^github\.com/rollkit/rollkit/da(@| )'
go list -m all | rg '^github\.com/rollkit/rollkit/sequencers/single(@| )'

Length of output: 543


rollkit module versions confirmed in module graph
The go list -m all output shows that rollkit, rollkit/core, rollkit/da, and rollkit/sequencers/single are all at v0.14.2-0.20250526094218-4a5686055970 with no stray versions in the build.

• Please verify that the pseudo-version’s commit hash 4a5686055970 matches the intended upstream revision.
• Ensure any breaking changes introduced in v0.14.2 have been addressed in your code.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tac0turtle tac0turtle merged commit 8dd3b8d into main May 26, 2025
13 checks passed
@tac0turtle tac0turtle deleted the julien/bump branch May 26, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants