Bump gradle/actions from 4 to 6 - #3
Closed
dependabot[bot] wants to merge 10 commits into
Closed
Conversation
Split out of the romm-jams working tree. Contains only the Android client: a Compose player over RomM's /api/music endpoints with device authorization sign-in, offline downloads, favorites and playlists backed by RomM collections, and handheld shoulder-button controls. Claude-Session: https://claude.ai/code/session_01KbKMKTsAM9nW1bgx4jCSj4
The media session is exported so the system's media surfaces can reach it, which also lets any installed app connect as a controller and hand the player a URI of its choosing. The data source attached the Bearer token to every http request, so an injected media item was enough to send the token to an arbitrary host. The resolver now attaches the token only when the request's scheme, host and port match the paired origin, and unrecognized controllers keep transport control but lose the commands that replace the queue. Origin normalization moves to RommApiFactory so a bare-host entry is stored with a scheme and the comparison cannot fail closed. Alongside that: exclude the auth DataStore from cloud backup and device transfer, so the token is no longer copied to Drive and restored onto other devices; allowlist the download extension before it reaches the MediaStore display name; trust user-installed CAs so a server behind a private CA can be reached over TLS; and drop the hardcoded development server address in favour of an empty field. Claude-Session: https://claude.ai/code/session_01KbKMKTsAM9nW1bgx4jCSj4
A release build with no keystore.properties fell back to the debug signing key, producing an artifact called a release that cannot install over one. It now fails with an explanation instead. Debug builds are untouched, so a CI job that only assembles debug still works without the file. Adopt the lint configuration used across the other Android projects here. The baseline captures 77 existing findings so new ones surface on their own; it is a list to work through, not a clean bill. Claude-Session: https://claude.ai/code/session_01KbKMKTsAM9nW1bgx4jCSj4
99 tests over the logic that fails silently when it breaks: origin matching for the stream auth header, server URL normalization, download naming and extension handling, media URL encoding, track mapping, and limit/offset pagination. Robolectric backs the tests that touch android.net.Uri so a stub cannot satisfy an assertion; unitTests isReturnDefaultValues stays off for the same reason. A few private helpers became internal so they could be exercised directly, and the stream resolver predicate moved out of the ResolvingDataSource lambda into streamAuthHeaders, which now takes the credentials as a lambda and so never reads the token for local URIs. sanitizeName also trims dots, so a name of ".." no longer reaches MediaStore as a relative path segment. detekt runs against config/detekt with a 3-entry baseline. Magic numbers are excluded under ui/, where the literal is the thing being expressed; the rest became named constants. Claude-Session: https://claude.ai/code/session_01KbKMKTsAM9nW1bgx4jCSj4
Four jobs on push to main and pull requests against it: assembleDebug, testDebugUnitTest, lintDebug, and detekt. Debug variants only, since release signing needs a keystore that is not in the repo and verifyReleaseSigningConfig fails the build without it. Also adds dependabot, CODEOWNERS, pull request and issue templates, a contributing guide, and an editorconfig. The gitignore now excludes per-machine agent config while leaving the shared skills tracked. Claude-Session: https://claude.ai/code/session_01KbKMKTsAM9nW1bgx4jCSj4
The privacy policy is derived from the source rather than from a template: the five declared permissions, the client token and device identifier sent at pairing, what stays on the device, the backup exclusion, and the cleartext and user-CA posture a self-hosted server requires. AGENTS.md records the constraints that are not obvious from reading one file, including the origin pinning on the stream auth header and the media session gating. The release and pre-release-validation skills document the release flow. Claude-Session: https://claude.ai/code/session_01KbKMKTsAM9nW1bgx4jCSj4
The album art now takes 0.47 of the disc diameter instead of 0.38, with the groove band and its separators moved out to start past the new label edge. Both the art size and the groove start derive from one constant so they cannot drift apart. The platter turns at 150 degrees per second rather than 200. The server address field now settles to a full origin when it loses focus and again on connect, so a bare host visibly gains its https:// instead of gaining it silently at request time. It reuses the same normalizeOrigin the request path already used, so the field cannot disagree with what gets contacted. Claude-Session: https://claude.ai/code/session_01KbKMKTsAM9nW1bgx4jCSj4
Bumps [gradle/actions](https://github.com/gradle/actions) from 4 to 6. - [Release notes](https://github.com/gradle/actions/releases) - [Commits](gradle/actions@v4...v6) --- updated-dependencies: - dependency-name: gradle/actions dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/github_actions/gradle/actions-6
branch
September 1, 2026 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps gradle/actions from 4 to 6.
Release notes
Sourced from gradle/actions's releases.
... (truncated)
Commits
9c97196Bump the github-actions group across 2 directories with 9 updates (#1024)760e4a4Bump the npm-dependencies group across 1 directory with 2 updates (#1037)73e4c42Update gradle-actions-caching library to v1.0.0 (#1029)a9d1438Add dependabot ignore rules for TypeScript 7.x and@types/node25.x/26.x68f3700[bot] Update dist directory5971332Bump Gradle Wrapper to 9.6.1, wrapper checksums, and Develocity plugin to 4.5...b5bc804[bot] Update dist directorydcbab4eBump npm-dependencies group with TypeScript 6.0.3,@types/node24.x, and secu...ca8d957Move non-smoke restore-gradle-home tests back to the integ-test suite (#1032)4318659[bot] Update dist directoryDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)