Skip to content

Update screenshots of saves when saving #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

saminitz
Copy link

@saminitz saminitz commented May 2, 2025

Description
Explain the changes or enhancements you are proposing with this pull request.

With this change, the screenshots of saves will also be updated, reducing confusion for users who might otherwise think their save didn't work just because the image didn't change. (me 😅)

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
    • I'm unable to do it
  • I've added unit tests that cover the changes

Screenshots

@saminitz saminitz changed the title when updating a save files also update the screenshot Update screenshots of saves when saving May 2, 2025
@gantoine gantoine changed the base branch from release to master May 5, 2025 00:44
@gantoine gantoine merged commit 385ee80 into rommapp:master May 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants