[HOTFIX] Rename selected_statuses to statuses

[gantoine]

Description
^{Explain the changes or enhancements you are proposing with this pull request.}

Checklist
^{Please check all that apply.}

• I've tested the changes locally
• I've updated relevant comments
• I've assigned reviewers for this PR
• I've added unit tests that cover the changes

[gemini-code-assist]

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses a refactoring initiative to standardize the naming convention for status-related filtering parameters from selected_statuses to statuses throughout the application's backend and frontend. This change enhances code readability and maintainability. Additionally, the PR incorporates updates to automatically generated frontend code, reflecting recent API schema changes that introduce new metadata structures for multiplayer game modes and player counts, alongside a new configuration setting for media scanning.

Highlights

• Parameter Renaming: The parameter selected_statuses has been consistently renamed to statuses across backend API endpoints, database filtering logic, and frontend service calls for improved clarity and consistency.
• Generated Code Updates: Frontend generated API client code has been updated to include new types and fields, such as IGDBMetadataMultiplayerMode, and new properties like multiplayer_modes and player_count in RomIGDBMetadata. The nullability of player_count has also been adjusted in RomMetadataSchema and RomSSMetadata.
• Configuration Enhancement: A new configuration option, SCAN_MEDIA, has been added to the frontend ConfigResponse and its default settings.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request renames the selected_statuses parameter to statuses across the backend and frontend for consistency. The changes are mostly straightforward.

However, I've identified a couple of issues:

• There's a potential backward compatibility issue in backend/handler/database/collections_handler.py that could break existing smart collections. I've left a comment with a suggestion to fix this.
• I've also suggested a minor refactoring in backend/handler/database/roms_handler.py to improve code clarity.

Additionally, this PR seems to include unrelated changes, particularly in the frontend's auto-generated files and configuration. These changes appear to be related to new features like multiplayer_modes and are outside the scope of a hotfix for renaming a variable. It's generally better to keep pull requests focused on a single concern to simplify review and reduce risk.

Please review my comments. Overall, good job on the rename, but the backward compatibility issue should be addressed.

[github-actions]

Test Results

703 tests  ±0   702 ✅ ±0   1m 28s ⏱️ +6s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 3965a89. ± Comparison against base commit 751aff5.

♻️ This comment has been updated with latest results.

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
12177	7904	65%	0%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
backend/endpoints/rom.py	44%	🟢
backend/handler/database/collections_handler.py	50%	🟢
backend/handler/database/roms_handler.py	54%	🟢
TOTAL	49%	🟢

updated for commit: 3965a89 by action🐍