Apply DISABLE_EMULATOR_JS to Console mode (disable Play + block direct player route) - #3373
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/rommapp/romm/sessions/67bb960a-e5ec-4569-bdeb-d8c90028c004 Co-authored-by: gantoine <3247106+gantoine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add option to disable console button in emulator
Apply May 14, 2026
DISABLE_EMULATOR_JS to Console mode (disable Play + block direct player route)
gantoine
approved these changes
May 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Console mode so DISABLE_EMULATOR_JS also blocks Console EmulatorJS launch paths, aligning Console behavior with the existing library-only/emulator-disabled contract.
Changes:
- Adds Console Game view disable-state handling for the Play action and button.
- Adds a direct-route guard in Console Play view to redirect away when EmulatorJS is disabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
frontend/src/console/views/Game.vue |
Adds a heartbeat-derived disabled flag, blocks play(), and disables/styles the Play button. |
frontend/src/console/views/Play.vue |
Imports heartbeat state and redirects direct Console player route visits when EmulatorJS is disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISABLE_EMULATOR_JSdisabled web-player entry points but Console mode could still launch EmulatorJS via the Console Play flow. This change aligns Console behavior with the existing emulator disable contract so RomM can run as library-only.Console Game view now respects emulator disable state
frontend/src/console/views/Game.vueplay()execution whenDISABLE_EMULATOR_JSis enabled.Direct Console player route is guarded
frontend/src/console/views/Play.vueDISABLE_EMULATOR_JSis enabled, route redirects toROUTES.CONSOLE_ROMinstead of booting EmulatorJS.Behavioral impact
DISABLE_EMULATOR_JS=true, matching non-console behavior.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
images.igdb.com/home/REDACTED/work/romm/romm/.venv/bin/pytest pytest -q(dns block)trunk.io/usr/bin/wget wget --verbose --tries=3 --limit-rate=10M REDACTED --output-document /home/REDACTED/.cache/trunk/cli/tmp.wmCWIfrXQG/launcher/install/download-1.25.0.tar.gz(dns block)/usr/bin/wget wget --verbose --tries=3 --limit-rate=10M REDACTED --output-document /home/REDACTED/.cache/trunk/cli/tmp.GhQf2quUso/launcher/install/download-1.25.0.tar.gz k/romm/romm/.git38273cb4b615bcd3cf358abfee6b67ff0c25ce3a51048bf7a4341b0be1ea268d 7ff0c25ce3a51048bf7a4341b0be1ea268d/log.json e1f326594d0e857e-q(dns block)/usr/bin/wget wget --verbose --tries=3 --limit-rate=10M REDACTED --output-document /home/REDACTED/.cache/trunk/cli/tmp.QPvx1ajRBY/launcher/install/download-1.25.0.tar.gz /opt/hostedtoolcache/uv/0.11.14/--systemd-cgroup 7ff0c25ce3a51048bf7a4341b0be1ea268d/log.json by/1dbdbdd52ae40-u ea6b77f1f6729997 b622b72087ed5fb4fe0f.pid conf�� --local s1809536002 ache/node/18.20.8/x64/lib/node_mjson by/38273cb4b615b/usr/bin/runc.original 7ff0c25ce3a51048bf7a4341b0be1ea268d/b901b933e8a91f7d66f9be4b0b170835ab0199d2dd472c25de740d9fab64c350.pid cf358abfee6b67ff/var/run/docker/runtime-runc/moby dad706e268ec0496--log(dns block)If you need me to access, download, or install something from one of these locations, you can either: