fix(docker): generate gunicorn logging config to writable /tmp path - #3383
Merged
Conversation
The init script ran `sed -i` against /etc/gunicorn/logging.conf, which fails both on read-only root filesystems and when the container runs as a non-root UID (since /etc/gunicorn is not chmod'd writable). Copy the config to /tmp/gunicorn/logging.conf at startup and edit/use that copy instead, leaving the image file untouched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the container init script to avoid mutating Gunicorn’s logging config under /etc at runtime, enabling startup in environments where /etc is read-only or not writable (e.g., non-root Kubernetes deployments).
Changes:
- Copy
/etc/gunicorn/logging.confto/tmp/gunicorn/logging.confon startup and apply theLOGLEVELsubstitution to the copied file. - Point Gunicorn’s
--log-configto the generated runtime config under/tmp. - Minor comment cleanup/clarification in the init script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sed -iagainst/etc/gunicorn/logging.confto wireLOGLEVELinto Gunicorn's logging config. This fails in two common Kubernetes deployment modes:securityContext.readOnlyRootFilesystem: true—/etcis read-only./etc/gunicornis not made writable in the Dockerfile (unlike/etc/nginx/conf.d), sosederrors withcan't create temp file '/etc/gunicorn/logging.confXXXXXX': Permission denied./etc/gunicorn/logging.confto/tmp/gunicorn/logging.conf, runsedon the copy, and pass that copy togunicorn --log-config. The image file under/etcis no longer mutated./tmpis writable in all deployment modes, so this resolves both cases without Dockerfile changes.Fixes the issue reported where RomM cannot start under
readOnlyRootFilesystem: trueor as a non-root UID in Kubernetes.Test plan
securityContext.readOnlyRootFilesystem: true./etc/gunicornbeing writable.LOGLEVEL=DEBUGis correctly reflected in the generated/tmp/gunicorn/logging.confand in Gunicorn's output.🤖 Generated with Claude Code