fix(playmatch): handle empty heartbeat query#3756
Merged
Merged
Conversation
DevYukine
marked this pull request as ready for review
July 15, 2026 23:50
Contributor
Greptile SummaryThis PR fixes Playmatch heartbeat requests with an empty query. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(playmatch): handle empty heartbeat q..." | Re-trigger Greptile |
gantoine
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The 5.0 metadata page checks the Playmatch health endpoint as soon as Playmatch is enabled. That check currently fails before sending a request because RomM expands an empty query into
yarl.URL.update_query(), which yarl rejects.This passes the query dictionary directly instead. Empty heartbeat queries now keep the original health URL, while normal identify queries still add their parameters.
Also adds a regression test for the Playmatch heartbeat request.
Disclosure
I am not a Python developer and am not very familiar with the RomM codebase. I used Codex using GPT 5.6 Sol to help with the Playmatch heartbeat bugfix and to validate the regression test. I reviewed the result before submitting.
Checklist
Please check all that apply.
Screenshots (if applicable)
Backend change only, no screenshots needed