Skip to content

fix(v2): link IGDB provider to game page by slug#3782

Merged
gantoine merged 1 commit into
masterfrom
posthog-code/v2-igdb-provider-link
Jul 16, 2026
Merged

fix(v2): link IGDB provider to game page by slug#3782
gantoine merged 1 commit into
masterfrom
posthog-code/v2-igdb-provider-link

Conversation

@gantoine

Copy link
Copy Markdown
Member

Description

The IGDB provider link in the v2 GameDetails provider grid built a text-search URL from the numeric provider ID (/search?type=1&q=<id>), which returns no results. This points the link at the canonical /games/<slug> page when the ROM's slug is present, and only falls back to the ID search when the slug is missing.

To support this, the Provider.url builder now receives the DetailedRom in addition to the ID, so builders can reach fields beyond the provider ID (both OverviewTab.vue and ProviderGrid.vue call sites updated).

Note

This change was written with AI assistance (PostHog Code). The author reviewed and verified the change.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Screenshots (if applicable)

N/A


Created with PostHog Code

The IGDB provider link built a text-search URL from the numeric ID,
which returns no results. Point it at the canonical /games/<slug> page
when the slug is present, falling back to the ID search otherwise. The
URL builder now receives the DetailedRom so it can reach fields beyond
the provider ID.

Generated-By: PostHog Code
Task-Id: 6843b623-ed80-454f-8373-8192f3c629b4
Copilot AI review requested due to automatic review settings July 16, 2026 22:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@greptile-apps

greptile-apps Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR changes IGDB links to open the canonical game page when a ROM slug is available. The main changes are:

  • Pass the full DetailedRom to provider URL builders.
  • Build IGDB game links from rom.slug.
  • Keep the numeric-ID search URL as a fallback.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
frontend/src/v2/components/GameDetails/OverviewTab.vue Passes the current DetailedRom to provider URL builders.
frontend/src/v2/components/GameDetails/ProviderGrid.vue Passes the ROM through while preserving the existing missing-ID and missing-builder guards.
frontend/src/v2/components/GameDetails/providers.ts Expands the URL-builder contract and uses the ROM slug for direct IGDB links.

Reviews (1): Last reviewed commit: "fix(v2): link IGDB provider to game page..." | Re-trigger Greptile

@gantoine
gantoine merged commit c3721a8 into master Jul 16, 2026
10 checks passed
@gantoine
gantoine deleted the posthog-code/v2-igdb-provider-link branch July 16, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants