fix(v2): link IGDB provider to game page by slug#3782
Merged
Conversation
The IGDB provider link built a text-search URL from the numeric ID, which returns no results. Point it at the canonical /games/<slug> page when the slug is present, falling back to the ID search otherwise. The URL builder now receives the DetailedRom so it can reach fields beyond the provider ID. Generated-By: PostHog Code Task-Id: 6843b623-ed80-454f-8373-8192f3c629b4
Contributor
Greptile SummaryThis PR changes IGDB links to open the canonical game page when a ROM slug is available. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(v2): link IGDB provider to game page..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The IGDB provider link in the v2 GameDetails provider grid built a text-search URL from the numeric provider ID (
/search?type=1&q=<id>), which returns no results. This points the link at the canonical/games/<slug>page when the ROM's slug is present, and only falls back to the ID search when the slug is missing.To support this, the
Provider.urlbuilder now receives theDetailedRomin addition to the ID, so builders can reach fields beyond the provider ID (bothOverviewTab.vueandProviderGrid.vuecall sites updated).Note
This change was written with AI assistance (PostHog Code). The author reviewed and verified the change.
Checklist
Screenshots (if applicable)
N/A
Created with PostHog Code