[WIP] feat: playable Win3.x and Win9.x using js-dos - #4061
Draft
bphenriques wants to merge 2 commits into
Draft
Conversation
gantoine
self-requested a review
August 1, 2026 23:10
bphenriques
force-pushed
the
3143-jsdos-backend
branch
from
August 3, 2026 10:36
cdc1651 to
1c56c39
Compare
bphenriques
force-pushed
the
3143-jsdos-backend
branch
from
August 3, 2026 10:45
1c56c39 to
f827acc
Compare
Author
|
Actions to review:
Will review later this week once my weekly limits resets. Taking a look by hand in the meantime (just slower). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft/WIP. I need to manually review the code, the PR description and the accompanying changes ot the docs.
Closes #3143
EmulatorJS (
dosbox-pure) boots DOS games but blank-screens Windows 3.x titles. This is a known limitation that can be solved by bringingjs-dosv8 (DOSBox-X backend) as a fourth in-browser player sowin3xandwin9xthat is known to address this gap.Related docs PR: rommapp/docs#110
Out of scope
To keep changes minimal:
js-doscan play DOS titles, for simplicity, DOS stays on EmulatorJS only. It is a minordosslug addition.Changes
This PR attempts to be as similar as other external players:
frontend/src/v2/views/Player/JsDos.vue/rom/:id/jsdosDISABLE_JSDOSjs-dosis added to the docker under/assets/jsdos, served same-origin (pinned).autoStart: trueandautoSave: true(matching EmulatorJS defaults).setNoCloud(true)as this is a self-hosted instance behind romm.Test Plan
Writing manual tests as automated tests are covered automatically by the CI/CD (or should).
Tested titles (auto start + saves):
Misc tests:
DISABLE_JSDOSAI assistance disclosure
This contribution was developed with the assistance of Claude (Anthropic), an AI
coding assistant. I reviewed, tested, and validated the design, implementation,
and tests, and I take responsibility for the change.