Catch up with the API changes in cargo_metadata 0.20#8
Merged
Conversation
Owner
|
Thanks a lot for your PR, really appreciated! Closes #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As explained in #7,
cargo_metadata0.20 introduces an incompatible API change, and the "0" version ofcargo-feature-combinations's dependency on it is not strict enough to handle that, which breaks the build.As noted in the issue itself, this pull request contains both options for fixing the build; feel free to pick one, tell me to rebase/squash/whatever as necessary, or, of course, choose a completely different way to deal with this as is your maintainer's right.
G'luck,
Peter