Add Archive and GitArchive output formats#173
Add Archive and GitArchive output formats#173moozzi wants to merge 16 commits intoronin-rb:0.2.0from
Archive and GitArchive output formats#173Conversation
This worker will accept a domain as input and, given a valid API key, will return a list of subdomain hosts by querying the Security Trails API. --------- Co-authored-by: Postmodern <postmodern.mod3@gmail.com>
…rb#165). * Left behind an alias for `ronin-recon test` to `ronin-recon run-worker`.
--------- Co-authored-by: Postmodern <postmodern.mod3@gmail.com>
--------- Co-authored-by: Postmodern <postmodern.mod3@gmail.com>
--------- Co-authored-by: Postmodern <postmodern.mod3@gmail.com>
--------- Co-authored-by: Postmodern <postmodern.mod3@gmail.com>
moozzi
force-pushed
the
add_archive_and_git_archive_output_formats
branch
from
c086226 to
5d844e0
Compare
postmodern
left a comment
postmodern
left a comment
There was a problem hiding this comment.
Sub-classing Ronin::Web::Spider::Archive classes might come back to bite us, if we ever change their APIs or if we add a << method to them. Using composition and initializing ivars might be a better option.
| # | ||
| # Represents a web archive directory. | ||
| # | ||
| class Archive < Ronin::Web::Spider::Archive |
There was a problem hiding this comment.
Sub-classing Ronin::Web::Spider::Archive might cause problems for us in the future if we ever change it's API. Might be safer to initialize it as an ivar in initialize.
| # The path to the root directory. | ||
| # | ||
| def initialize(root) | ||
| super(root) |
There was a problem hiding this comment.
Might be safer to initialize Ronin::Web::Spider::GitArchive as an ivar.
postmodern
left a comment
postmodern
left a comment
There was a problem hiding this comment.
To avoid confusion, we should name these new output formats web_archive and git_web_archive (or web_git_archive). This should indicate to the user that only the URLs will be saved into the archive.
moozzi
force-pushed
the
add_archive_and_git_archive_output_formats
branch
from
5d844e0 to
8d62799
Compare
postmodern
left a comment
postmodern
left a comment
There was a problem hiding this comment.
Forgot to rename the classes to match the output-format names.
| register :png, '.png', PNG | ||
| register :pdf, '.pdf', PDF | ||
| register :web_archive, '', Archive | ||
| register :web_git_archive, '', GitArchive |
There was a problem hiding this comment.
Rename classes to WebArchive and GitArchive.
There was a problem hiding this comment.
The file-exts can be omitted now that they are optional.
| # | ||
| # Represents a web archive directory. | ||
| # | ||
| class Archive |
| # | ||
| # Represents a web archive directory that is backed by Git. | ||
| # | ||
| class GitArchive |
There was a problem hiding this comment.
Rename class to WebGitArchive.
postmodern
force-pushed
the
0.2.0
branch
2 times, most recently
from
14a8e49 to
c3e8f79
Compare
postmodern
force-pushed
the
0.2.0
branch
2 times, most recently
from
3af1090 to
c350d3b
Compare
3 participants
#146