docs(adr): source-modeling discipline — Track G G0#186
Open
ronsse wants to merge 1 commit into
Open
Conversation
…mple) Track G Wave 1 unit G0. Codifies the project's stance on graph granularity decisions, with columns as the canonical worked example: columns are properties (not nodes), searchability runs through a denormalized `column_names` flat list on the existing DSL, the extractor warns (does not reject) on `entity_type` matching a tight blocklist, the regulated-column exception requires both `allow_structural_leaf=True` and `node_role=STRUCTURAL`, and column-level lineage by name-match across tables is forbidden. G1 ships the validator + blocklist constant; G2 ships the SDK example update + cookbook recipe + contract test. This ADR is the contract they target. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/design/adr-source-modeling-discipline.md(~235 lines) codifying the project's stance on graph granularity decisions, with columns as the canonical worked example.properties.columns(structured) +properties.column_names(flat denormalized list for exact-match search via existinginfilter).allow_structural_leaf: bool = False) onEntityRuleandEntityDraft. Soft validator emits structlog WARNING onentity_typein{"Column", "column", "TableColumn", "table_column"}blocklist unless flag set. Does NOT reject mutations.allow_structural_leaf=TrueANDnode_role="structural"for the rare case where column-level entities earn their own nodes (PII / governance lifecycle).edge.properties.column_pairsannotations.Test plan
docs/agent-guide/modeling-guide.md(Schema explosion anti-pattern) anddocs/agent-guide/source-modeling-cookbook.md(existing column guidance)adr-canonical-graph-layer.md§4 + §8.2 resolve (the deferral of nested-path DSL operators)ENTITY_TYPE_ANTI_PATTERNS) matches sibling Unit G1's implementationvalidate_entity_type_not_anti_pattern) matches sibling Unit G1's implementation🤖 Generated with Claude Code