Skip to content

Commit

Permalink
updates. removing outdated ruby versions
Browse files Browse the repository at this point in the history
  • Loading branch information
simonoff committed Feb 8, 2025
1 parent 134ae21 commit 857cb84
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 25 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ jobs:
fail-fast: false
matrix:
ruby:
- '2.7'
- '3.0'
- '3.1'
- '3.2'
- '3.3'
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@
.buildpath
*~
.bundle/
lbin/
lbin/
vendor
19 changes: 8 additions & 11 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
require: rubocop-performance

AllCops:
TargetRubyVersion: 2.4
TargetRubyVersion: 3.1
# RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
# to ignore them, so only the ones explicitly set in this file are enabled.
DisabledByDefault: true
SuggestExtensions: false

Performance:
Exclude:
Expand All @@ -13,12 +16,6 @@ Performance:
Style/AndOr:
Enabled: true

# Do not use braces for hash literals when they are the last argument of a
# method call.
Style/BracesAroundHashParameters:
Enabled: true
EnforcedStyle: context_dependent

# Align `when` with `case`.
Layout/CaseIndentation:
Enabled: true
Expand Down Expand Up @@ -127,26 +124,26 @@ Style/StringLiterals:
EnforcedStyle: double_quotes

# Detect hard tabs, no hard tabs.
Layout/Tab:
Layout/IndentationStyle:
Enabled: true

# Blank lines should not have any spaces.
Layout/TrailingBlankLines:
Layout/TrailingEmptyLines:
Enabled: true

# No trailing whitespace.
Layout/TrailingWhitespace:
Enabled: true

# Use quotes for string literals when they are enough.
Style/UnneededPercentQ:
Style/RedundantPercentQ:
Enabled: true

# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
Lint/RequireParentheses:
Enabled: true

Lint/StringConversionInInterpolation:
Lint/RedundantStringCoercion:
Enabled: true

Lint/UriEscapeUnescape:
Expand Down
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
## Unreleased

### Changed/Added
- Add dependencies for `csv` and `base64` if Ruby version higher or equal 3.4
- Add dependencies for `csv` and `base64` if Ruby version higher or equal 3.4 [616](https://github.com/roo-rb/roo/pull/616)
- Add dependency for `logger` if Ruby version higher or equal 3.4 [618](https://github.com/roo-rb/roo/pull/618)
- Add changelog link to gemspec [605](https://github.com/roo-rb/roo/pull/605)

### Removed
- Support for ruby 2.7, 3.0

## [2.10.1] 2024-01-17

Expand Down
7 changes: 5 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,18 @@ source 'https://rubygems.org'

gemspec

gem 'rubocop'
gem 'rubocop-performance', require: false

group :test do
# additional testing libs
gem 'shoulda'
gem 'activesupport', '< 5.1'
gem 'activesupport'
gem 'rspec', '>= 3.0.0'
gem 'simplecov', '>= 0.9.0', require: false
gem 'coveralls', require: false
gem "minitest-reporters"
gem 'webrick' if RUBY_VERSION >= '3.0.0'
gem 'webrick'
end

group :local_development do
Expand Down
12 changes: 4 additions & 8 deletions roo.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,25 +17,21 @@ Gem::Specification.new do |spec|
spec.files.reject! { |fn| fn.include?('test/files') }
spec.require_paths = ['lib']

if defined?(RUBY_ENGINE) && RUBY_ENGINE == 'jruby'
spec.required_ruby_version = ">= 2.6.0"
else
spec.required_ruby_version = ">= 2.7.0"
end
spec.required_ruby_version = ">= 3.1.0"

if RUBY_VERSION >= '3.4.0'
spec.add_dependency 'base64', '~> 0.2'
spec.add_dependency 'csv', '~> 3'
spec.add_dependency 'logger', '~> 1'
end

spec.add_dependency 'nokogiri', '~> 1'
spec.add_dependency 'rubyzip', '>= 1.3.0', '< 3.0.0'

spec.add_development_dependency 'rake'
spec.add_development_dependency 'minitest', '~> 5.4', '>= 5.4.3'
spec.add_development_dependency 'rack', '~> 1.6', '< 2.0.0'
if RUBY_VERSION >= '3.0.0'
spec.add_development_dependency 'matrix'
end
spec.add_development_dependency 'matrix'

spec.metadata["changelog_uri"] = spec.homepage + '/blob/master/CHANGELOG.md'
end

0 comments on commit 857cb84

Please sign in to comment.