[fortran] explore if occassional memory corruption issue stems from substring replacement #18234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 8 files 8 suites 3d 8h 59m 33s ⏱️ For more details on these failures, see this check. Results for commit 0053a0a. ♻️ This comment has been updated with latest results. |
…ubstring replacement by adding a space, we create an extra char that will be substituted by c, rather than appending to the string
ferdymercury
commented
Apr 3, 2025
| @@ -312,7 +312,7 @@ int main(int argc, char **argv) | |||
|
|
|||
| int lun = 10; | |||
| #ifndef WIN32 | |||
| hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),PASSCHAR("px"),record_size,ier,7,strlen(file_in),2); | |||
| hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),PASSCHAR("px "),record_size,ier,7,strlen(file_in),2); | |||
There was a problem hiding this comment.
Suggested change
| hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),PASSCHAR("px "),record_size,ier,7,strlen(file_in),2); | |
| hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),PASSCHAR("px"),record_size,ier,7,strlen(file_in),2); |
Does not seem to make much difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
By adding a space, we create an extra char that, on Fortran's side will be substituted by c, rather than appending to the string.
Related discussion: https://github.com/root-project/root/pull/15915/files
Fixes #15422
Fixes #14155