Skip to content

[fortran] explore if occassional memory corruption issue stems from substring replacement #18234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[fortran] explore if occassional memory corruption issue stems from substring replacement #18234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b12393b
[fortran] explore if occassional memory corruption issue stems from s…
ferdymercury Apr 2, 2025
317c4f5
[ci] trigger known failure when enabling fortran
ferdymercury Apr 2, 2025
4ce7688
extra spaces
ferdymercury Apr 2, 2025
0053a0a
enable warnings and sanitizer
ferdymercury Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/root-ci-config/buildconfig/alma8.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@ builtin_gtest=ON
builtin_nlohmannjson=ON
builtin_tbb=ON
builtin_vdt=On
fortran=OFF
tmva-sofie=On
ccache=On
1 change: 0 additions & 1 deletion .github/workflows/root-ci-config/buildconfig/mac-beta.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ builtin_zeromq=ON
builtin_zstd=ON
ccache=ON
cocoa=ON
fortran=OFF
pythia8=OFF
test_distrdf_dask=ON
test_distrdf_pyspark=ON
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/root-ci-config/buildconfig/mac13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ builtin_zeromq=ON
builtin_zstd=ON
ccache=ON
cocoa=ON
fortran=OFF
pythia8=OFF
test_distrdf_dask=ON
test_distrdf_pyspark=ON
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/root-ci-config/buildconfig/mac14.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ builtin_zeromq=ON
builtin_zstd=ON
ccache=ON
cocoa=ON
fortran=OFF
pythia8=OFF
test_distrdf_dask=ON
test_distrdf_pyspark=ON
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/root-ci-config/buildconfig/mac15.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ builtin_zeromq=ON
builtin_zstd=ON
ccache=ON
cocoa=ON
fortran=OFF
pythia8=OFF
test_distrdf_dask=ON
test_distrdf_pyspark=ON
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/root-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ jobs:
- image: alma9
is_special: true
property: march_native
overrides: ["CMAKE_BUILD_TYPE=RelWithDebInfo", "CMAKE_CXX_FLAGS=-march=native", "CMAKE_C_FLAGS=-march=native", "fortran=OFF"]
overrides: ["CMAKE_BUILD_TYPE=RelWithDebInfo", "CMAKE_CXX_FLAGS=-march=native", "CMAKE_C_FLAGS=-march=native"]
- image: alma9
is_special: true
property: arm64
Expand Down
2 changes: 1 addition & 1 deletion main/src/h2root.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ int main(int argc, char **argv)

int lun = 10;
#ifndef WIN32
hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),PASSCHAR("px"),record_size,ier,7,strlen(file_in),2);
hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),PASSCHAR("px "),record_size,ier,7,strlen(file_in),2);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),PASSCHAR("px "),record_size,ier,7,strlen(file_in),2);
hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),PASSCHAR("px"),record_size,ier,7,strlen(file_in),2);

Does not seem to make much difference.

#else
hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),PASSCHAR("px"),record_size,ier);
#endif
Expand Down
4 changes: 3 additions & 1 deletion misc/minicern/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,6 @@ target_link_libraries(minicern ${CMAKE_Fortran_IMPLICIT_LINK_LIBRARIES})
# Disable optimization since it some cases was causing crashes.
# Disable warnings, since what has worked for 40 years...
# (see https://sft.its.cern.ch/jira/browse/ROOT-9179 for the warnings)
set_target_properties(minicern PROPERTIES COMPILE_FLAGS "-O0 -w")
# set_target_properties(minicern PROPERTIES COMPILE_FLAGS "-O0 -w")
set_target_properties(minicern PROPERTIES COMPILE_FLAGS "-fsanitize=undefined -fsanitize=address")
target_link_options(minicern BEFORE PUBLIC -fsanitize=undefined PUBLIC -fsanitize=address)
Loading