JsMVA: use latest JSROOT, use /static path to load code
#12484
Conversation
|
Starting build on |
Test Results 10 files 10 suites 2d 5h 40m 24s ⏱️ Results for commit 9624d9a. ♻️ This comment has been updated with latest results. |
While JSROOT has absolutely different modules structure, just try to use build.js bundle. It also include d3_select, which can be reused.
Like JSROOT, let use /static path which provided by Jupyter notebooks Avoid usage of minified scripts - this reduce number of steps needed to deploy JsMVA. Use d3 from external location
This let access them from Jupyter Notebooks via /static/mva/ path. Remove minified script to simplify deplyment Add missing jquery scripts
There was a problem hiding this comment.
Thank you very much! I tested that JsMVA works the same way before and after this PR 👍 Let's merge this.
I helped you reviving this PR because it was my fault that there were conflicts: I have moved all the files around without giving you the opportunity to merge this PR first 🫤
|
Are all python3 problems resolved now? |
|
No, I didn't try anything besides the unit tests in What do you mean with Python 3 problems? We don't support Python 2 anymore, so all code only needs to run in Python 3. Which is does, right? Sorry, maybe I didn't get the problem. If you mean with Python 3 problems the error you have screenshot: I get the same error also without your PR. So given that JsROOT is not working very well and no user complained, I would not spend more time on this and suggest to merge this PR and close the issue. |
|
This commit b9d085e is adjusting to python3. I am not sure if changes in other scripts is necessary.
Here problem not jsroot but jsMVA. I have no tests to check functionality of NeuralNetwork. Most probably it will not work after merging PR. Therefore I prefer test it before merging. |
| @@ -23,7 +23,7 @@ def __init__(self, shell): | |||
| @magic_arguments() | |||
| @argument("arg", nargs="?", default="on", help="Enable/Disable JavaScript visualisation for TMVA") | |||
| def jsmva(self, line): | |||
| from JsMVA.JPyInterface import functions | |||
| from ROOT.JsMVA.JPyInterface import functions | |||
There was a problem hiding this comment.
This is fixed in master branch (using a relative import):
from .JPyInterface import functions
| @@ -19,7 +19,7 @@ | |||
| paths: { | |||
| "jquery-connections": baseURL + "jquery.connections.min", | |||
| "jquery-timing": baseURL + "jquery-timing.min", | |||
| "d3": "/static/scripts/d3.min" | |||
| "d3": "https://d3js.org/d3.v6.min" | |||
There was a problem hiding this comment.
Could this us the module from jsroot?
"/static/modules/d3.mjs "
There was a problem hiding this comment.
I do not think that ES6 module can be used here.
One have to use alternative location
Fixes #12441
js/mva/folder which can be accessed via/static/mva/URL from Jupyter Notebook. This allows to use JsMVA code directly from ROOT without need to rely onhttps://root.cern/js/jsmva/latestJsMVA.jscode to JSROOT v7. Use bundle provided inbuild/jsroot.js.OutputTransformer.pyto work with python3, probably other scripts should be improved as wellNetworkDesigner.jsto use d3 v6, load d3 from external sourceStill to do:
python3- see attached image from my notebookNeuralNetwork.jsto be usable with latest d3.js. I need working example for it.