[RF] Fix RooAddPdf::expectedEvents() in conditional fits
#12954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 13 files 13 suites 2d 21h 41m 58s ⏱️ Results for commit 38aba9c. ♻️ This comment has been updated with latest results. |
So far, the projection coefficient for coefficients in RooAddPdfs was missing in `RooAddPdf::expectedEvents()`. However, this is important to include in conditional fits where the normalization set of `expectedEvents()` is different from the normalization set for coefficient determination. This PR includes this missing factor. A unit test that covers both the case where the expected events are taken from the coefs and the one where they are taken from the pdfs is included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the projection coefficient for coefficients in RooAddPdfs was missing in
RooAddPdf::expectedEvents(). However, this is important to include in conditional fits where the normalization set ofexpectedEvents()is different from the normalization set for coefficient determination. This PR includes this missing factor.A unit test that covers both the case where the expected events are taken from the coefs and the one where they are taken from the pdfs is included.