Skip to content

[PyROOT][RF] Feature to import datasets and modelConfig using JSON I/O and a new tutorial #13553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[PyROOT][RF] Feature to import datasets and modelConfig using JSON I/O and a new tutorial #13553

wants to merge 3 commits into from

Conversation

yashnator
Copy link
Contributor

This Pull request:

  • Adds the feature to import datasets and modelConfigs to RooWorkspace using the RooJSONFactoryWSTool.
  • Adds a new Pythonic tutorial for fitting and plotting using single-channel data

Changes:

  • RooJSONFactoryWSTool to import binned & unbinned datasets and modelConfigs
  • Adds a FitModelAndPlot overload to perform measurement using RooWorkspace
  • A new tutorial hf101.py

Checklist:

  • tested changes locally
  • updated the docs

@phsft-bot
Copy link

Can one of the admins verify this patch?

@yashnator yashnator force-pushed the tutorial-roofit-nll branch from b0eb2a7 to 1aa9345 Compare August 28, 2023 15:21
@yashnator
Feat: Add FitModelAndPlot overload to directly use a RooWorkspace
7027af3 
- Add FitModelAndPlot overload that fits and plots using a RooWorkspace
instead of a Measurement.
@yashnator
Feat: Import datasets & modelConfigs using JSON I/O
1868dd8 
- Add the support to import binned & unbinned datasets and modelConfigs
to a workspace using the `importJSONElement` method
@yashnator
Docs: Add the hf101.py tutorial, a Pythonic analogue of hf_001.C
2b1ed7e 
- Add the hf101.py tutorial for for Pythonic fitting and modelling
using a single channel dataset from RooWorspace, analogous to the
hf_001.C
@yashnator yashnator force-pushed the tutorial-roofit-nll branch from 1aa9345 to 2b1ed7e Compare August 28, 2023 15:38
@guitargeek guitargeek self-assigned this Aug 29, 2023
@couet couet removed their request for review December 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

@guitargeek guitargeek Awaiting requested review from guitargeek guitargeek is a code owner

@hageboeck hageboeck Awaiting requested review from hageboeck

At least 1 approving review is required to merge this pull request.

Assignees

@guitargeek guitargeek

Labels
in:RooFit/RooStats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashnator @phsft-bot @guitargeek