-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[http] let use external civetweb #14194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
With -Dbuiltin_civetweb=OFF one can try to find and build ROOT with exetrnal version of civetweb. But this external version should be compiled with websocket support - which is not always a case
2c23757
to
9fe88db
Compare
@Axel-Naumann there is no |
@linev since it's a new option and |
@bellenot You see error messages in the begin? It is exactly this. |
What about this: I will install civetweb on distros where it exists, and we use those. For platforms where it doesn't exist we use the builtin. 👍 👎 ? |
Most probably civetweb from distros compiled without websocket support and therefore unusable for us. |
This is how opensuse build civetweb: https://build.opensuse.org/package/show/server:http/civetweb It uses wrong build flags and enables mostly nothing. |
Also finalize at the end. Not really necessary, but to stay conform with API
When external civetweb package is used, it can be compiled without important options. Add necesary checks before starting http server
On opensuse platform one observe failures calling R__memcompress from civetweb request handler. Disable zipping of content for a time been.
With
-Dbuiltin_civetweb=OFF
one can try to find and build ROOT with external version of civetweb.But this external version should be compiled with websocket support - which is not always a case
For instance, does not work on OpenSUSE, where civetweb compiled without websockets