Skip to content

[http] let use external civetweb #14194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

linev
Copy link
Member

@linev linev commented Dec 7, 2023

With -Dbuiltin_civetweb=OFF one can try to find and build ROOT with external version of civetweb.
But this external version should be compiled with websocket support - which is not always a case

For instance, does not work on OpenSUSE, where civetweb compiled without websockets

With -Dbuiltin_civetweb=OFF one can try to find and build ROOT
with exetrnal version of civetweb. But this external version should
be compiled with websocket support - which is not always a case
@linev linev force-pushed the external_civetweb branch from 2c23757 to 9fe88db Compare December 7, 2023 16:11
Copy link

github-actions bot commented Dec 7, 2023

Test Results

       10 files         10 suites   2d 4h 41m 46s ⏱️
  2 485 tests   2 485 ✔️ 0 💤 0
23 773 runs  23 773 ✔️ 0 💤 0

Results for commit d3bbeca.

♻️ This comment has been updated with latest results.

@bellenot
Copy link
Member

bellenot commented Dec 8, 2023

@Axel-Naumann there is no civetweb in the CI (neither in rootspi nor in root/.github/workflows). Should it be added? And should it be builtin_civetweb=ON everywhere by default?
EDIT: Ooops! Sorry, it's a new option...

@bellenot
Copy link
Member

bellenot commented Dec 8, 2023

@linev since it's a new option and ON by default, it should not fail in Jenkins...

@linev
Copy link
Member Author

linev commented Dec 8, 2023

@bellenot You see error messages in the begin? It is exactly this.
As I understand, @Axel-Naumann create list of supported options and all others disabled by default.
One need to add builtin_civetweb into such list.

@Axel-Naumann
Copy link
Member

What about this: I will install civetweb on distros where it exists, and we use those. For platforms where it doesn't exist we use the builtin. 👍 👎 ?

@linev
Copy link
Member Author

linev commented Dec 8, 2023

@Axel-Naumann

Most probably civetweb from distros compiled without websocket support and therefore unusable for us.
I get in contact with OpenSUSE maintainer of civetweb, but it will take time before something will come out.

@linev
Copy link
Member Author

linev commented Dec 11, 2023

This is how opensuse build civetweb:

https://build.opensuse.org/package/show/server:http/civetweb

It uses wrong build flags and enables mostly nothing.
I hope to change it - but it also requires some changes in civetweb cmake. See:

civetweb/civetweb#1225

civetweb/civetweb#1226

Also finalize at the end.
Not really necessary, but to stay conform with API
When external civetweb package is used,
it can be compiled without important options.
Add necesary checks before starting http server
On opensuse platform one observe failures calling R__memcompress
from civetweb request handler. Disable zipping of content
for a time been.
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from linev May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from linev May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from linev May 21, 2024
@root-project root-project deleted a comment from linev May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from bellenot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from linev May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
@root-project root-project deleted a comment from phsft-bot May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants