Skip to content

[TMath] Add moving mean, moving median and mode #15097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pitkajuh
Copy link
Contributor

@pitkajuh pitkajuh commented Mar 30, 2024

This Pull request:

Changes or fixes:

Dear all. This pull request adds moving mean, moving median and mode to Root's TMath. I tried to update the documentation (https://root.cern/doc/v630/namespaceTMath.html) but I could not figure out where to find the files on Github. Please can someone guide me?

I will leave the PR in draft state. I will appreciate any feedback you can give me.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #14258
LastTest.log.tar.gz

@phsft-bot
Copy link

Can one of the admins verify this patch?

Copy link

github-actions bot commented Apr 1, 2024

Test Results

     8 files       8 suites   1d 16h 13m 42s ⏱️
 2 573 tests  2 573 ✅ 0 💤 0 ❌
19 933 runs  19 933 ✅ 0 💤 0 ❌

Results for commit 2c241ef.

♻️ This comment has been updated with latest results.

@ferdymercury
Copy link
Collaborator

Thanks for your PR !
The documentation is automatically generated based on the comments on top of the function implementation. No need to modify anything extra.
You have to follow the Doxygen format.
So please use things like the \param \return keywords.

      /**
       * a normal member taking two arguments and returning an integer value.
       * \param a an integer argument.
       * \param s a constant character pointer.
       * \see Javadoc_Test()
       * \return The test results
       */

@pitkajuh pitkajuh force-pushed the fix-14258-mov-mean branch 4 times, most recently from eeb6197 to 2c241ef Compare April 13, 2024 07:48
@pitkajuh
Copy link
Contributor Author

Dear All. I edited the according to suggestions and added descriptions for the functions. If there is anything you want me to change, please let me know.

@pitkajuh pitkajuh marked this pull request as ready for review April 13, 2024 07:52
@pitkajuh pitkajuh requested a review from lmoneta as a code owner April 13, 2024 07:52
@pitkajuh
Copy link
Contributor Author

FYI, some of the suggestions given for #15100 are also applicable in this PR. I will make changes accordingly.

@pitkajuh pitkajuh force-pushed the fix-14258-mov-mean branch from fa32c76 to 477936f Compare May 10, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[math] Moving average/median/mode
4 participants