Skip to content

[PyROOT] Move CPython extensions in subdirectories #15310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[PyROOT] Move CPython extensions in subdirectories #15310

wants to merge 1 commit into from

Conversation

guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Apr 22, 2024 •
edited
Loading

Closes #14917.

@guitargeek guitargeek self-assigned this Apr 22, 2024
@guitargeek guitargeek mentioned this pull request Apr 22, 2024
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

Test Results

    18 files      18 suites   4d 3h 56m 6s ⏱️
 2 690 tests  2 326 ✅ 0 💤 364 ❌
46 724 runs  45 996 ✅ 0 💤 728 ❌

For more details on these failures, see this check.

Results for commit cae535e.

♻️ This comment has been updated with latest results.

@guitargeek guitargeek force-pushed the issue-14917 branch 3 times, most recently from 5bcf33c to 15e6162 Compare April 29, 2024 15:28
@guitargeek guitargeek added this to the 6.32/00 milestone Apr 29, 2024
@guitargeek guitargeek force-pushed the issue-14917 branch 2 times, most recently from dc560e3 to 9e24937 Compare May 5, 2024 10:41
@ferdymercury ferdymercury modified the milestones: 6.32/00, 6.32.04 Jun 18, 2024
@guitargeek guitargeek removed this from the 6.32.04 milestone Jun 28, 2024
@dpiparo dpiparo closed this Aug 26, 2024
@dpiparo dpiparo reopened this Aug 26, 2024
@dpiparo
Copy link
Member

dpiparo commented Aug 26, 2024

I am re-running all tests since we had some failures a while ago.

dpiparo
dpiparo approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as all tests pass.

@dpiparo dpiparo closed this Oct 30, 2024
@dpiparo dpiparo reopened this Oct 30, 2024
@dpiparo
Copy link
Member

dpiparo commented Oct 30, 2024

@guitargeek it seems this generates several segfaults, basically on all plarforms, but only for some tests: do you manage to make sense of those?

@guitargeek guitargeek force-pushed the issue-14917 branch 3 times, most recently from 0a70e44 to dc94d64 Compare January 3, 2025 18:54
@guitargeek guitargeek requested a review from couet as a code owner January 3, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpiparo dpiparo dpiparo approved these changes

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@vepadulano vepadulano Awaiting requested review from vepadulano vepadulano is a code owner

@couet couet Awaiting requested review from couet

Assignees

@guitargeek guitargeek

Labels
improvement in:Python Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ROOT installs libraries at the top-level site-packages directory
3 participants
@guitargeek @dpiparo @ferdymercury