[core] Replace CINT with CLING #15513
Conversation
in preprocessor statements. Fixes root-project#10058
dpiparo
requested review from
agheata,
bellenot,
couet,
gganis,
jblomer,
linev,
lmoneta,
osschar,
pcanal and
vepadulano
as code owners
|
Thank you for the initiative! You're also replacing Maybe @pcanal can confirm, but from that paragraph I understand that the replacement for |
Test Results 10 files 10 suites 1d 18h 30m 11s ⏱️ For more details on these failures, see this check. Results for commit ede7404. |
| if (strstr(cs, "#ifndef__CINT__") || | ||
| strstr(cs, "#if!defined(__CINT__)")) |
There was a problem hiding this comment.
Do we want to check here for both, __CINT__ and __CLING__?
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
See my comment before
| *************************************************************************/ | ||
|
|
||
| #ifdef __CINT__ | ||
| #ifdef __CLING__ |
There was a problem hiding this comment.
A more semantically accurate replacement within a LinkDef file is:
| #ifdef __CLING__ | |
| #ifdef __ROOTCLING__ |
(i.e. needed only during dictionary generation and not during interpretation)
| }; | ||
|
|
||
| #if !defined (__CINT__) || defined (__MAKECINT__) | ||
| #if !defined (__CLING__) || defined (__MAKECLING__) |
There was a problem hiding this comment.
| #if !defined (__CLING__) || defined (__MAKECLING__) | |
| #if !defined (__CLING__) || defined (__ROOTCLING__) |
| /// | ||
| /// ~~~{.cpp} | ||
| /// #if defined(__CINT__) && !defined(__MAKECINT__) | ||
| /// #if defined(__CLING__) && !defined(__MAKECLING__) |
There was a problem hiding this comment.
| /// #if defined(__CLING__) && !defined(__MAKECLING__) | |
| /// #if defined(__CLING__) && !defined(__ROOTCLING__) |
| void runIt() { | ||
|
|
||
| #if defined(__CINT__) && !defined(__MAKECINT__) | ||
| #if defined(__CLING__) && !defined(__MAKECLING__) |
There was a problem hiding this comment.
| #if defined(__CLING__) && !defined(__MAKECLING__) | |
| #if defined(__CLING__) && !defined(__ROOTCLING__) |
|
|
||
| void mathcoreVectorFloatIO() { | ||
| #if defined(__CINT__) && !defined(__MAKECINT__) | ||
| #if defined(__CLING__) && !defined(__MAKECLING__) |
There was a problem hiding this comment.
| #if defined(__CLING__) && !defined(__MAKECLING__) | |
| #if defined(__CLING__) && !defined(__ROOTCLING__) |
4 participants
in preprocessor statements.
Fixes #10058