-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[RF] Faster Hesse in RooFit by advertising which params are independent #16394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
eae7b17
to
6e8c228
Compare
Test Results 18 files 18 suites 4d 11h 12m 15s ⏱️ For more details on these failures, see this check. Results for commit 3fa8122. ♻️ This comment has been updated with latest results. |
The error seems an unresolved symbol on Win
|
5a2d19a
to
04afc01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this improvement! Let's not forget to give to this feature the right emphasis in the RNs.
04afc01
to
9ebb89a
Compare
f3f761d
to
5d5d765
Compare
5d5d765
to
82825d7
Compare
This reduces the time to run Hesse in the ATLAS Higgs benchmark from 123 s to 92 seconds. Given that some models take hours for this, this is a significant improvement for the user experience. Further improvement is possible by analyzing the computation graph a bit more to find more independent parameters (e.g., the different gammas for stat uncertainties from different bins).
82825d7
to
3fa8122
Compare
This reduces the time to run Hesse in the ATLAS Higgs benchmark from
123 s to 92 seconds.
Given that some models take hours for this, this is a significant
improvement for the user experience.
Further improvement is possible by analyzing the computation graph a bit
more to find more independent parameters (e.g., the different gammas for
stat uncertainties from different bins).
Benchmark results
The Higgs combination benchmark takes 31 s to minimize, plus 79 s for the Hessian with ROOT
master
. It was 130 seconds with ROOTmaster
just a few days ago, before some optimization PRs got merged. This PR reduces the time forhesse()
to 57 seconds.