Skip to content

Enable Auto-Loading Support in Root/LLVM #17227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

SahilPatidar
Copy link

This Pull request:

In this PR, I have attempted to integrate auto-loading changes from PR, which were initially implemented based on Lang Hames' suggestions for out-of-process execution. Here, I have applied the same logic to root cling for in-process execution. These changes are in the very early stages of auto-loading development and require further improvements and potential design refinements. Suggestions and feedback are highly encouraged!

Changes or fixes:

Checklist:

  • tested changes locally : (Only ctest -R cling )
  • updated the docs (if necessary)

This PR fixes #

Copy link

github-actions bot commented Dec 9, 2024

Test Results

    17 files      17 suites   4d 6h 20m 58s ⏱️
 2 722 tests  2 721 ✅ 0 💤 1 ❌
44 831 runs  44 830 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 5259660.

♻️ This comment has been updated with latest results.

@SahilPatidar
Copy link
Author

Ok, I'll need to find a way to move some of Cling's platform utilities to ORC to resolve the build failures on other platforms.

@SahilPatidar
Copy link
Author

@bellenot do you understand what this error is about in the Windows build:

C:\Program Files (x86)\Windows Kits\10\Include\10.0.22621.0\um\winnt.h(169,1): error C1189: #error:  "No Target Architecture" [C:\ROOT-CI\build\interpreter\llvm-project\llvm\lib\ExecutionEngine\Orc\Shared\LLVMOrcShared.vcxproj]
    (compiling source file '../../../../../../../../src/interpreter/llvm-project/llvm/lib/ExecutionEngine/Orc/Shared/AutoLoadDyLoader.cpp')```

@vgvassilev
Copy link
Member

vgvassilev commented Feb 20, 2025

@bellenot do you understand what this error is about in the Windows build:

C:\Program Files (x86)\Windows Kits\10\Include\10.0.22621.0\um\winnt.h(169,1): error C1189: #error:  "No Target Architecture" [C:\ROOT-CI\build\interpreter\llvm-project\llvm\lib\ExecutionEngine\Orc\Shared\LLVMOrcShared.vcxproj]
    (compiling source file '../../../../../../../../src/interpreter/llvm-project/llvm/lib/ExecutionEngine/Orc/Shared/AutoLoadDyLoader.cpp')```

Internet tells me something as weird as we are missing some include...

@bellenot
Copy link
Member

@bellenot do you understand what this error is about in the Windows build:

C:\Program Files (x86)\Windows Kits\10\Include\10.0.22621.0\um\winnt.h(169,1): error C1189: #error:  "No Target Architecture" [C:\ROOT-CI\build\interpreter\llvm-project\llvm\lib\ExecutionEngine\Orc\Shared\LLVMOrcShared.vcxproj]
    (compiling source file '../../../../../../../../src/interpreter/llvm-project/llvm/lib/ExecutionEngine/Orc/Shared/AutoLoadDyLoader.cpp')```

Well, I don't know, but it sounds like a missing flag for the architecture (Win32/x86/x64 or whatever is the proper syntax)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants