-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Enable Auto-Loading Support in Root/LLVM #17227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test Results 17 files 17 suites 4d 6h 20m 58s ⏱️ For more details on these failures, see this check. Results for commit 5259660. ♻️ This comment has been updated with latest results. |
Ok, I'll need to find a way to move some of Cling's platform utilities to ORC to resolve the build failures on other platforms. |
@bellenot do you understand what this error is about in the Windows build: C:\Program Files (x86)\Windows Kits\10\Include\10.0.22621.0\um\winnt.h(169,1): error C1189: #error: "No Target Architecture" [C:\ROOT-CI\build\interpreter\llvm-project\llvm\lib\ExecutionEngine\Orc\Shared\LLVMOrcShared.vcxproj]
(compiling source file '../../../../../../../../src/interpreter/llvm-project/llvm/lib/ExecutionEngine/Orc/Shared/AutoLoadDyLoader.cpp')``` |
Internet tells me something as weird as we are missing some include... |
Well, I don't know, but it sounds like a missing flag for the architecture (Win32/x86/x64 or whatever is the proper syntax)... |
This Pull request:
In this PR, I have attempted to integrate auto-loading changes from PR, which were initially implemented based on Lang Hames' suggestions for out-of-process execution. Here, I have applied the same logic to root cling for in-process execution. These changes are in the very early stages of auto-loading development and require further improvements and potential design refinements. Suggestions and feedback are highly encouraged!
Changes or fixes:
Checklist:
ctest -R cling
)This PR fixes #