[interpreter] Always build LLVM with C++17#17735
Merged
hahnjo merged 2 commits intoroot-project:masterfrom Mar 23, 2025
Merged
Conversation
hahnjo
added
in:Build System
in:Cling
clean build
1 task
Test Results 20 files 20 suites 4d 23h 22m 52s ⏱️ For more details on these failures, see this check. Results for commit a3a9d49. ♻️ This comment has been updated with latest results. |
Member
Author
|
Do we want this for 6.36? llvm/llvm-project#127459 was merged upstream (+ backported to LLVM 20), but I can also create a tag for our LLVM 18, let me know. |
Member
|
Yes, thanks: It would be useful to have this for 6.36. |
Member
Author
|
ping @dpiparo @vgvassilev |
dpiparo
approved these changes
Mar 21, 2025
JSONScopedPrinter has a std::unique_ptr<DelimitedScope> member and defaulted constructor argument, so it needs a complete type. This resolves one of the many build errors with C++23 using Clang. Backport of llvm/llvm-project#127459
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17686