[RF] New PDF: gaussian with double sided exponential tails #17976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdymercury
requested review from
bellenot,
lmoneta and
guitargeek
as code owners
ferdymercury
commented
Mar 12, 2025
Test Results 15 files 15 suites 3d 9h 58m 25s ⏱️ Results for commit deb9d9c. ♻️ This comment has been updated with latest results. |
|
Hello! Thanks a lot for this, it is extremely useful. About the naming: this distribution has been used in ALICE since well before the paper from Souvik Das, see for instance https://www.worldscientific.com/doi/epdf/10.1142/S0217751X14300440 figure 42 and some code implementation here that was published in 2015. Just to say that it might be fine to just call it for what it is and avoid name attributions. |
ferdymercury
commented
Mar 13, 2025
dpiparo
reviewed
Mar 31, 2025
ferdymercury
commented
Mar 31, 2025
It's a simpler alternative too RooCrystalBall with potentially less instabilities Fixes https://its.cern.ch/jira/browse/ROOT-8093 [RF] assert for devON avoid warning
[RF] Rename RooGaussExpTailDas.h to RooGaussExpTails.h [RF] Rename RooGaussExpTailDas.cxx to RooGaussExpTails.cxx
Thanks dpiparo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes https://its.cern.ch/jira/browse/ROOT-8093
It's a simpler alternative to RooCrystalBall with potentially less instabilities
Checklist: