Skip to content

[RF] copy-paste barlow-beeston to new class with explicit Conway name #18090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ferdymercury
Copy link
Contributor

@ferdymercury ferdymercury commented Mar 21, 2025

Fixes #15252

This Pull request:

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

Copy link

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit c2e16eb.

@ferdymercury
Copy link
Contributor Author

@HDembinski would you like to propose two things into this PR based on your reported issue?

  • Replace current BarlowBeestonLL with exact computation
  • Provide a third class using the approximation from your paper

@HDembinski
Copy link
Contributor

Yes, I can do that. Would be good to have a common base class for the Conway approximation and my implementation, because they are very similar, except for the actual computation of the likelihood.

@ferdymercury
Copy link
Contributor Author

ferdymercury commented Mar 21, 2025

Yes, I can do that. Would be good to have a common base class for the Conway approximation and my implementation, because they are very similar, except for the actual computation of the likelihood.

Thanks! Makes sense. Or maybe even a single class RooBarlowBeeston with a private enum member that chooses which approx to choose: 0 = Exact, 1 = Conway, 2 = Dembinski ? (And erasing RooBarlowBeestonLLConway)

@pcanal pcanal dismissed a stale review March 23, 2025 15:30

Please tell us why you approve this request.

@ferdymercury ferdymercury added this to the 6.38.00 milestone Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RF] Missing and misleading documentation in RooBarlowBeestonLL.cxx
3 participants