-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[skip-ci][ntuple] Fix-up RField<T>
documentation
#18116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
enirolf
merged 3 commits into
root-project:master
from
enirolf:ntuple-docs-rfield-other
Apr 25, 2025
Merged
[skip-ci][ntuple] Fix-up RField<T>
documentation
#18116
enirolf
merged 3 commits into
root-project:master
from
enirolf:ntuple-docs-rfield-other
Apr 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverweed
reviewed
Mar 24, 2025
5253281
to
5ce6df3
Compare
silverweed
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
vepadulano
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments inline, but I approve because I believe they might be addressed in a followup PR.
The generated documentation contained design considerations not relevant for users. We keep them around for our internal code documentation, but provide something more appropriate for the user-facing documentation.
5ce6df3
to
baaaadb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.