Skip to content

[skip-ci][ntuple] Fix-up RField<T> documentation #18116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025

Conversation

enirolf
Copy link
Contributor

@enirolf enirolf commented Mar 24, 2025

No description provided.

@enirolf enirolf force-pushed the ntuple-docs-rfield-other branch from 5253281 to 5ce6df3 Compare March 26, 2025 08:41
@enirolf enirolf requested a review from silverweed March 26, 2025 08:42
Copy link
Contributor

@silverweed silverweed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments inline, but I approve because I believe they might be addressed in a followup PR.

enirolf added 3 commits April 25, 2025 09:34
The generated documentation contained design considerations not relevant
for users. We keep them around for our internal code documentation, but
provide something more appropriate for the user-facing documentation.
@enirolf enirolf force-pushed the ntuple-docs-rfield-other branch from 5ce6df3 to baaaadb Compare April 25, 2025 07:38
@enirolf enirolf requested a review from pcanal as a code owner April 25, 2025 07:38
@enirolf enirolf merged commit af43461 into root-project:master Apr 25, 2025
6 checks passed
@enirolf enirolf deleted the ntuple-docs-rfield-other branch April 25, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants