Skip to content

Split long-running test #18124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Split long-running test #18124

merged 1 commit into from
Apr 16, 2025

Conversation

vepadulano
Copy link
Member

@vepadulano vepadulano commented Mar 25, 2025 •
edited
Loading

Splits ntuple_extended test into its subtests in different files, allowing for better parallelization in ctest runs.

@vepadulano vepadulano self-assigned this Mar 25, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

Test Results

    18 files      18 suites   4d 1h 41m 3s ⏱️
 2 741 tests  2 741 ✅ 0 💤 0 ❌
47 663 runs  47 663 ✅ 0 💤 0 ❌

Results for commit b8d5692.

♻️ This comment has been updated with latest results.

@vepadulano
Copy link
Member Author

I have re-instated the original ntuple_extended test, so we can get a runtime comparison at the same time between the integral test and the split subtests

@vepadulano
Copy link
Member Author

Anecdotally, here is what I see from the latest CI run

https://github.com/root-project/root/actions/runs/14086677685/job/39452494192?pr=18124

sequential test:
ntuple-extended 55s

parallel tests:
ntuple-double32imt 0.6s
ntuple-largefile1 17s
ntuple-largefile2 19.3s
ntuple-largepages 8s
ntuple-multicolumnexpansion 1.2s
ntuple-randomaccess 21.6s
ntuple-realworld1 5.4s

sum of runtimes for all sub-tests that have run in parallel: 73s

silverweed
silverweed approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@silverweed silverweed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

hahnjo
hahnjo reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we want to inflate the number of tests with a single unit test per binary. In particular ntuple-double32imt, ntuple-largepages, ntuple-multicolumnexpansion, and ntuple-realworld1 maybe look a bit questionable to me. Maybe leave them in ntuple-extended and just split off the others?

hahnjo
hahnjo approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LG!

@vepadulano
[ntuple] Split long-running test
b8d5692 
Split the `ntuple_extended.cxx` test into multiple test files, separating the
three tests that take the longest: largefile1, largefile2, randomaccess. This is
done in order to have better parallelization in the test suite.
@vepadulano vepadulano requested a review from pcanal as a code owner April 16, 2025 10:01
@dpiparo dpiparo merged commit 0b3dd80 into root-project:master Apr 16, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahnjo hahnjo hahnjo approved these changes

@pcanal pcanal pcanal approved these changes

@silverweed silverweed silverweed approved these changes

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@jblomer jblomer Awaiting requested review from jblomer

Assignees

@vepadulano vepadulano

Labels
in:RNTuple
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vepadulano @hahnjo @pcanal @silverweed @dpiparo